From 74fe3f2ef3d66d1eaf4564467c9a34bfe3561d30 Mon Sep 17 00:00:00 2001 From: Michal Simek Date: Wed, 31 Mar 2021 09:05:52 +0200 Subject: [PATCH] cmd: dfu: Propagate error if dfu gadget fails On systems without usb gadget dfu core fails which was reported by error but command itself returns pass which breaks any usage in a script. That's why propagate error from run_usb_dnl_gadget(). Fixes: 16297cfb2a20 ("usb: new board-specific USB init interface") Signed-off-by: Michal Simek --- cmd/dfu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/dfu.c b/cmd/dfu.c index ef4f897ce0..4a288f74c2 100644 --- a/cmd/dfu.c +++ b/cmd/dfu.c @@ -68,7 +68,7 @@ static int do_dfu(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) int controller_index = simple_strtoul(usb_controller, NULL, 0); bool retry = false; do { - run_usb_dnl_gadget(controller_index, "usb_dnl_dfu"); + ret = run_usb_dnl_gadget(controller_index, "usb_dnl_dfu"); if (dfu_reinit_needed) { dfu_free_entities();