brain-hackers_pepepper-mirror
/
u-boot-brain
mirror of https://github.com/brain-hackers/u-boot-brain
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

cmd: fix clone coverity scan 

This patch fixes coverity scan MISSING_BREAK issues, and also an error
on block size check.

Signed-off-by: John Chau <john@harmon.hk>
This commit is contained in:
John Chau 2020-08-17 15:53:01 +08:00 committed by Tom Rini
parent 10e4d64e34
commit 4a1f0b80ad
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cmd/clone.c
View File

@ -38,7 +38,7 @@ static int do_clone(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv
srcbz = srcdesc->blksz;
destbz = destdesc->blksz;
if ((srcbz * (buffersize / srcbz) != buffersize) &&
if ((srcbz * (buffersize / srcbz) != buffersize) ||
(destbz * (buffersize / destbz) != buffersize)) {
printf("failed: cannot match device block sizes\n");
return 1;
@ -55,10 +55,12 @@ static int do_clone(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv
switch (unit[0]) {
case 'g':
case 'G':
requested *= 1024;
requested *= 1024 * 1024 * 1024;
break;
case 'm':
case 'M':
requested *= 1024;
requested *= 1024 * 1024;
break;
case 'k':
case 'K':
requested *= 1024;