Qu Wenruo c6f1f12a8c btrfs: qgroup: mark qgroup inconsistent if we're inherting snapshot to a new qgroup ... [ Upstream commit cbab8ade585a18c4334b085564d9d046e01a3f70 ] [BUG] For the following operation, qgroup is guaranteed to be screwed up due to snapshot adding to a new qgroup: # mkfs.btrfs -f $dev # mount $dev $mnt # btrfs qgroup en $mnt # btrfs subv create $mnt/src # xfs_io -f -c "pwrite 0 1m" $mnt/src/file # sync # btrfs qgroup create 1/0 $mnt/src # btrfs subv snapshot -i 1/0 $mnt/src $mnt/snapshot # btrfs qgroup show -prce $mnt/src qgroupid rfer excl max_rfer max_excl parent child -------- ---- ---- -------- -------- ------ ----- 0/5 16.00KiB 16.00KiB none none --- --- 0/257 1.02MiB 16.00KiB none none --- --- 0/258 1.02MiB 16.00KiB none none 1/0 --- 1/0 0.00B 0.00B none none --- 0/258 ^^^^^^^^^^^^^^^^^^^^ [CAUSE] The problem is in btrfs_qgroup_inherit(), we don't have good enough check to determine if the new relation would break the existing accounting. Unlike btrfs_add_qgroup_relation(), which has proper check to determine if we can do quick update without a rescan, in btrfs_qgroup_inherit() we can even assign a snapshot to multiple qgroups. [FIX] Fix it by manually marking qgroup inconsistent for snapshot inheritance. For subvolume creation, since all its extents are exclusively owned, we don't need to rescan. In theory, we should call relation check like quick_update_accounting() when doing qgroup inheritance and inform user about qgroup accounting inconsistency. But we don't have good mechanism to relay that back to the user in the snapshot creation context, thus we can only silently mark the qgroup inconsistent. Anyway, user shouldn't use qgroup inheritance during snapshot creation, and should add qgroup relationship after snapshot creation by 'btrfs qgroup assign', which has a much better UI to inform user about qgroup inconsistent and kick in rescan automatically. Reviewed-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-06-22 09:31:09 +02:00
..
9p	9p pull request for inclusion in 5.4	2019-09-27 15:10:34 -07:00
adfs	Merge branch 'work.adfs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 11:33:22 -07:00
affs	affs: fix a memory leak in affs_remount	2020-01-17 19:48:50 +01:00
afs	rxrpc: Fix the excessive initial retransmission timeout	2020-05-27 17:46:48 +02:00
autofs	autofs: fix a leak in autofs_expire_indirect()	2019-10-25 00:03:11 -04:00
befs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
bfs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
btrfs	btrfs: qgroup: mark qgroup inconsistent if we're inherting snapshot to a new qgroup	2020-06-22 09:31:09 +02:00
cachefiles	cachefiles: Fix race between read_waiter and read_copier involving op->to_do	2020-06-03 08:21:11 +02:00
ceph	ceph: flush release queue when handling caps for unknown inode	2020-06-03 08:21:25 +02:00
cifs	smb3: add indatalen that can be a non-zero value to calculation of credit charge in smb2 ioctl	2020-06-17 16:40:27 +02:00
coda	y2038: add inode timestamp clamping	2019-09-19 09:42:37 -07:00
configfs	configfs: fix config_item refcnt leak in configfs_rmdir()	2020-05-27 17:46:30 +02:00
cramfs	cramfs: fix usage on non-MTD device	2019-11-23 21:44:49 -05:00
crypto	fscrypt: don't evict dirty inodes after removing key	2020-03-18 07:17:53 +01:00
debugfs	debugfs: Check module state before warning in {full/open}_proxy_open()	2020-04-17 10:50:02 +02:00
devpts	devpts_pty_kill(): don't bother with d_delete()	2019-09-03 09:30:56 -04:00
dlm	dlm for 5.3	2019-07-12 17:37:53 -07:00
ecryptfs	ecryptfs: replace BUG_ON with error handling code	2020-02-28 17:22:26 +01:00
efivarfs	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
efs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
erofs	erofs: correct the remaining shrink objects	2020-04-17 10:50:16 +02:00
exportfs	exportfs_decode_fh(): negative pinned may become positive without the parent locked	2019-11-10 11:56:05 -05:00
ext2	ext2: fix debug reference to ext2_xattr_cache	2020-04-23 10:36:41 +02:00
ext4	ext4: check for non-zero journal inum in ext4_calculate_overhead	2020-05-02 08:49:01 +02:00
f2fs	f2fs: fix to avoid memory leakage in f2fs_listxattr	2020-04-29 16:32:55 +02:00
fat	fat: don't allow to mount if the FAT length == 0	2020-06-17 16:40:36 +02:00
freevxfs	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
fscache	Revert "Merge tag 'keys-acl-20190703' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs"	2019-07-10 18:43:43 -07:00
fuse	fuse: fix stack use after return	2020-03-18 07:17:52 +01:00
gfs2	gfs2: Even more gfs2_find_jhead fixes	2020-06-17 16:40:21 +02:00
hfs	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
hfsplus	hfsplus: fix crash and filesystem corruption when deleting files	2020-04-17 10:50:22 +02:00
hostfs	This pull request contains the following changes for UML:	2019-05-12 17:52:13 -04:00
hpfs	fs: hpfs: Initialize filesystem timestamp ranges	2019-08-30 08:11:25 -07:00
hugetlbfs	mm/hugetlbfs: fix for_each_hstate() loop in init_hugetlbfs_fs()	2020-01-04 19:19:19 +01:00
iomap	iomap: fix return value of iomap_dio_bio_actor on 32bit systems	2020-01-04 19:17:31 +01:00
isofs	y2038: add inode timestamp clamping	2019-09-19 09:42:37 -07:00
jbd2	jbd2: improve comments about freeing data buffers whose page mapping is NULL	2020-04-21 09:04:52 +02:00
jffs2	Revert "jffs2: Fix possible null-pointer dereferences in jffs2_add_frag_to_fragtree()"	2019-12-04 22:31:06 +01:00
jfs	y2038: add inode timestamp clamping	2019-09-19 09:42:37 -07:00
kernfs	kernfs: fix ino wrap-around detection	2019-12-13 08:42:53 +01:00
lockd	lockd: Make two symbols static	2019-07-03 17:52:09 -04:00
minix	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
nfs	NFSv3: fix rpc receive buffer size for MOUNT call	2020-05-20 08:20:27 +02:00
nfs_common	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
nfsd	nfsd: memory corruption in nfsd4_lock()	2020-05-02 08:48:46 +02:00
nilfs2	nilfs2: fix null pointer dereference at nilfs_segctor_do_construct()	2020-06-17 16:40:29 +02:00
nls	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
notify	fanotify: fix ignore mask logic for events on child and on dir	2020-06-17 16:40:24 +02:00
ntfs	utimes: Clamp the timestamps in notify_change()	2020-02-11 04:35:12 -08:00
ocfs2	dlmfs_file_write(): fix the bogosity in handling non-zero *ppos	2020-05-06 08:15:09 +02:00
omfs	fs: omfs: Initialize filesystem timestamp ranges	2019-08-30 08:11:25 -07:00
openpromfs	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
orangefs	help_next should increase position index	2020-02-24 08:37:02 +01:00
overlayfs	ovl: initialize error in ovl_copy_xattr	2020-06-17 16:40:32 +02:00
proc	proc: Use new_inode not new_inode_pseudo	2020-06-17 16:40:33 +02:00
pstore	pstore: pstore_ftrace_seq_next should increase position index	2020-04-17 10:50:12 +02:00
qnx4	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
qnx6	fs: Fill in max and min timestamps in superblock	2019-08-30 07:27:17 -07:00
quota	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:21:37 +01:00
ramfs	vfs: Convert ramfs, shmem, tmpfs, devtmpfs, rootfs to use the new mount API	2019-09-12 21:05:34 -04:00
reiserfs	reiserfs: prevent NULL pointer dereference in reiserfs_insert_item()	2020-02-24 08:37:00 +01:00
romfs	Merge branch 'work.mount2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-09-19 10:06:57 -07:00
squashfs	Merge branch 'work.mount2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-09-19 10:06:57 -07:00
sysfs	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
sysv	fs: sysv: Initialize filesystem timestamp ranges	2019-08-30 07:27:18 -07:00
tracefs	tracing: Do not create tracefs files if tracefs lockdown is in effect	2019-10-12 20:49:07 -04:00
ubifs	ubifs: remove broken lazytime support	2020-05-27 17:46:14 +02:00
udf	udf: Fix free space reporting for metadata and virtual partitions	2020-02-24 08:36:44 +01:00
ufs	y2038: add inode timestamp clamping	2019-09-19 09:42:37 -07:00
unicode	unicode: make array 'token' static const, makes object smaller	2019-09-17 11:48:24 -04:00
verity	fs-verity: support builtin file signatures	2019-08-12 19:33:50 -07:00
xfs	xfs: fix duplicate verification from xfs_qm_dqflush()	2020-06-22 09:31:03 +02:00
aio.c	aio: fix async fsync creds	2020-06-17 16:40:24 +02:00
anon_inodes.c	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
attr.c	utimes: Clamp the timestamps in notify_change()	2020-02-11 04:35:12 -08:00
bad_inode.c
binfmt_aout.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
binfmt_elf_fdpic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
binfmt_elf.c	fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()	2020-06-03 08:21:27 +02:00
binfmt_em86.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
binfmt_flat.c	fs/binfmt_flat.c: remove set but not used variable 'inode'	2019-07-16 19:23:22 -07:00
binfmt_misc.c	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
binfmt_script.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
block_dev.c	hibernate: Allow uswsusp to write to swap	2020-04-23 10:36:34 +02:00
buffer.c	ext4: use non-movable memory for superblock readahead	2020-04-23 10:36:15 +02:00
char_dev.c	chardev: Avoid potential use-after-free in 'chrdev_open()'	2020-01-14 20:08:18 +01:00
compat_binfmt_elf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 193	2019-05-30 11:29:21 -07:00
compat_ioctl.c	fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP	2020-01-09 10:20:05 +01:00
compat.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
coredump.c	coredump: fix crash when umh is disabled	2020-05-14 07:58:27 +02:00
d_path.c	[PATCH] fix d_absolute_path() interplay with fsmount()	2019-08-30 19:31:09 -04:00
dax.c	dax: pass NOWAIT flag to iomap_apply	2020-03-05 16:43:36 +01:00
dcache.c	Merge branch 'work.dcache2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-20 09:15:51 -07:00
dcookies.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
direct-io.c	fs/direct-io.c: fix kernel-doc warning	2019-10-14 15:04:01 -07:00
drop_caches.c	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:21:37 +01:00
eventfd.c	eventfd: track eventfd_signal() recursion depth	2020-02-11 04:35:37 -08:00
eventpoll.c	eventpoll: fix missing wakeup for ovflist in ep_poll_callback	2020-05-14 07:58:26 +02:00
exec.c	exec: Move would_dump into flush_old_exec	2020-05-20 08:20:34 +02:00
fcntl.c	fs: mark expected switch fall-throughs	2019-04-08 18:21:02 -05:00
fhandle.c	fs/handle.c - fix up kerneldoc	2019-08-07 21:51:47 -04:00
file_table.c	vfs: Export flush_delayed_fput for use by knfsd.	2019-08-19 11:00:39 -04:00
file.c	fix multiplication overflow in copy_fdtable()	2020-05-27 17:46:12 +02:00
filesystems.c	fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()	2020-04-17 10:50:21 +02:00
fs_context.c	vfs: subtype handling moved to fuse	2019-09-06 21:28:49 +02:00
fs_parser.c	vfs: Make fs_parse() handle fs_param_is_fd-type params better	2019-09-12 21:06:14 -04:00
fs_pin.c	switch the remnants of releasing the mountpoint away from fs_pin	2019-07-16 22:52:37 -04:00
fs_struct.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
fs_types.c
fs-writeback.c	memcg: fix a crash in wb_workfn when a device disappears	2020-02-11 04:35:11 -08:00
fsopen.c	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
inode.c	futex: Fix inode life-time issue	2020-03-25 08:25:58 +01:00
internal.h	fs: move guard_bio_eod() after bio_set_op_attrs	2020-01-17 19:48:21 +01:00
io_uring.c	io_uring: use kvfree() in io_sqe_buffer_register()	2020-06-17 16:40:26 +02:00
ioctl.c	compat_ioctl: add compat_ptr_ioctl()	2019-12-17 19:55:30 +01:00
Kconfig	fs-verity for 5.4	2019-09-18 16:59:14 -07:00
Kconfig.binfmt	binfmt_flat: make support for old format binaries optional	2019-06-24 09:16:47 +10:00
libfs.c	libfs: fix infoleak in simple_attr_read()	2020-04-01 11:02:17 +02:00
locks.c	locks: reinstate locks_delete_block optimization	2020-03-25 08:25:41 +01:00
Makefile	fs-verity for 5.4	2019-09-18 16:59:14 -07:00
mbcache.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
mount.h	switch the remnants of releasing the mountpoint away from fs_pin	2019-07-16 22:52:37 -04:00
mpage.c	fs: move guard_bio_eod() after bio_set_op_attrs	2020-01-17 19:48:21 +01:00
namei.c	namei: only return -ECHILD from follow_dotdot_rcu()	2020-03-05 16:43:48 +01:00
namespace.c	fs/namespace.c: fix use-after-free of mount in mnt_warn_timestamp_expiry()	2019-10-16 23:15:09 -04:00
no-block.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
nsfs.c	vfs: Convert nsfs to use the new mount API	2019-05-25 18:00:06 -04:00
open.c	cifs_atomic_open(): fix double-put on late allocation failure	2020-03-18 07:17:51 +01:00
pipe.c	vfs: Convert pipe to use the new mount API	2019-05-25 18:00:07 -04:00
pnode.c	propagate_one(): mnt_set_mountpoint() needs mount_lock	2020-05-02 08:48:44 +02:00
pnode.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 209	2019-05-30 11:29:53 -07:00
posix_acl.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
proc_namespace.c	vfs: subtype handling moved to fuse	2019-09-06 21:28:49 +02:00
read_write.c	fs: allow deduplication of eof block into the end of the destination file	2020-02-11 04:35:23 -08:00
readdir.c	readdir: be more conservative with directory entry names	2020-01-29 16:45:31 +01:00
select.c	fs/select.c: use struct_size() in kmalloc()	2019-07-16 19:23:25 -07:00
seq_file.c	seq_file: fix problem when seeking mid-record	2019-08-13 16:06:52 -07:00
signalfd.c	fs: mark expected switch fall-throughs	2019-04-08 18:21:02 -05:00
splice.c	splice: only read in as much information as there is pipe buffer space	2019-12-17 19:56:52 +01:00
stack.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
stat.c
statfs.c	vfs: Fix EOVERFLOW testing in put_compat_statfs64	2019-10-03 14:21:35 -07:00
super.c	Fix use after free in get_tree_bdev()	2020-05-06 08:15:15 +02:00
sync.c	fs/sync.c: sync_file_range(2) may use WB_SYNC_ALL writeback	2019-05-14 09:47:50 -07:00
timerfd.c	timerfd: Prepare for PREEMPT_RT	2019-08-01 20:51:23 +02:00
userfaultfd.c	userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK	2020-01-04 19:18:32 +01:00
utimes.c	utimes: Clamp the timestamps in notify_change()	2020-02-11 04:35:12 -08:00
xattr.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00