e9e2ce00ae
commit 928150fad41ba16df7fcc9f7f945747d0f56cbb6 upstream.
In esd_usb2_setup_rx_urbs() MAX_RX_URBS coherent buffers are allocated
and there is nothing, that frees them:
1) In callback function the urb is resubmitted and that's all
2) In disconnect function urbs are simply killed, but URB_FREE_BUFFER
is not set (see esd_usb2_setup_rx_urbs) and this flag cannot be used
with coherent buffers.
So, all allocated buffers should be freed with usb_free_coherent()
explicitly.
Side note: This code looks like a copy-paste of other can drivers. The
same patch was applied to mcba_usb driver and it works nice with real
hardware. There is no change in functionality, only clean-up code for
coherent buffers.
Fixes:
|
||
|---|---|---|
| .. | ||
| kvaser_usb | ||
| peak_usb | ||
| Kconfig | ||
| Makefile | ||
| ems_usb.c | ||
| esd_usb2.c | ||
| gs_usb.c | ||
| mcba_usb.c | ||
| ucan.c | ||
| usb_8dev.c | ||