linux-brain/fs/overlayfs
chenying a701ae9a0d ovl: fix BUG_ON() in may_delete() when called from ovl_cleanup()
commit 52d5a0c6bd8a89f460243ed937856354f8f253a3 upstream.

If function ovl_instantiate() returns an error, ovl_cleanup will be called
and try to remove newdentry from wdir, but the newdentry has been moved to
udir at this time.  This will causes BUG_ON(victim->d_parent->d_inode !=
dir) in fs/namei.c:may_delete.

Signed-off-by: chenying <chenying.kernel@bytedance.com>
Fixes: 01b39dcc95 ("ovl: use inode_insert5() to hash a newly created inode")
Link: https://lore.kernel.org/linux-unionfs/e6496a94-a161-dc04-c38a-d2544633acb4@bytedance.com/
Cc: <stable@vger.kernel.org> # v4.18
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-09-22 12:26:37 +02:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
copy_up.c ovl: fix missing revert_creds() on error path 2021-05-14 09:44:16 +02:00
dir.c ovl: fix BUG_ON() in may_delete() when called from ovl_cleanup() 2021-09-22 12:26:37 +02:00
export.c ovl: fix uninitialized pointer read in ovl_lookup_real_one() 2021-09-03 10:08:12 +02:00
file.c ovl: add splice file read write helper 2021-08-26 08:36:19 -04:00
inode.c ovl: perform vfs_getxattr() with mounter creds 2021-02-17 10:35:15 +01:00
namei.c ovl: fix lookup failure on multi lower squashfs 2019-12-17 19:56:10 +01:00
overlayfs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ovl_entry.h ovl: fix lookup failure on multi lower squashfs 2019-12-17 19:56:10 +01:00
readdir.c ovl: fix wrong WARN_ON() in ovl_cache_update_ino() 2020-02-11 04:35:24 -08:00
super.c ovl: allow upperdir inside lowerdir 2021-05-07 10:51:38 +02:00
util.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00