linux-brain/fs/fuse
Miklos Szeredi e904621ae0 fuse: fix use after free in fuse_read_interrupt()
[ Upstream commit e1e71c168813564be0f6ea3d6740a059ca42d177 ]

There is a potential race between fuse_read_interrupt() and
fuse_request_end().

TASK1
  in fuse_read_interrupt(): delete req->intr_entry (while holding
  fiq->lock)

TASK2
  in fuse_request_end(): req->intr_entry is empty -> skip fiq->lock
  wake up TASK3

TASK3
  request is freed

TASK1
  in fuse_read_interrupt(): dereference req->in.h.unique ***BAM***

Fix by always grabbing fiq->lock if the request was ever interrupted
(FR_INTERRUPTED set) thereby serializing with concurrent
fuse_read_interrupt() calls.

FR_INTERRUPTED is set before the request is queued on fiq->interrupts.
Dequeing the request is done with list_del_init() but FR_INTERRUPTED is not
cleared in this case.

Reported-by: lijiazi <lijiazi@xiaomi.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-09-22 12:26:43 +02:00
..
Kconfig virtio-fs: add virtiofs filesystem 2019-09-18 20:17:50 +02:00
Makefile virtio-fs: Change module name to virtiofs.ko 2019-10-14 10:20:33 +02:00
acl.c fuse: fix bad inode 2021-01-09 13:44:54 +01:00
control.c convenience helper: get_tree_single() 2019-07-04 22:01:58 -04:00
cuse.c cuse: prevent clone 2021-05-19 10:08:22 +02:00
dev.c fuse: fix use after free in fuse_read_interrupt() 2021-09-22 12:26:43 +02:00
dir.c fuse: fix bad inode 2021-01-09 13:44:54 +01:00
file.c fuse: flush extending writes 2021-09-15 09:47:41 +02:00
fuse_i.h fuse: fix write deadlock 2021-05-11 14:04:16 +02:00
inode.c fuse: fix bad inode 2021-01-09 13:44:54 +01:00
readdir.c fuse: fix bad inode 2021-01-09 13:44:54 +01:00
virtio_fs.c virtiofs: fix memory leak in virtio_fs_probe() 2021-05-11 14:04:14 +02:00
xattr.c fuse: fix bad inode 2021-01-09 13:44:54 +01:00