2370d94aed
[ Upstream commit ad6f93e9cd56f0b10e9b22e3e137d17a1a035242 ]
Clang static analysis reports this representative error
init.c:2501:18: warning: Array access (from variable 'queuedata') results
in a null pointer dereference
templ |= ((queuedata[i] & 0xc0) << 3);
This is the problem block of code
if(ModeNo > 0x13) {
...
if(SiS_Pr->ChipType == SIS_730) {
queuedata = &FQBQData730[0];
} else {
queuedata = &FQBQData[0];
}
} else {
}
queuedata is not set in the else block
Reviewing the old code, the arrays FQBQData730 and FQBQData were
used directly.
So hoist the setting of queuedata out of the if-else block.
Fixes:
|
||
---|---|---|
.. | ||
300vtbl.h | ||
310vtbl.h | ||
Makefile | ||
init.c | ||
init.h | ||
init301.c | ||
init301.h | ||
initdef.h | ||
initextlfb.c | ||
oem300.h | ||
oem310.h | ||
sis.h | ||
sis_accel.c | ||
sis_accel.h | ||
sis_main.c | ||
sis_main.h | ||
vgatypes.h | ||
vstruct.h |