Xin Long 176ef96c19 sctp: call gso_reset_checksum when computing checksum in sctp_gso_segment ... [ Upstream commit fc228abc23 ] Jianlin reported a panic when running sctp gso over gre over vlan device: [ 84.772930] RIP: 0010:do_csum+0x6d/0x170 [ 84.790605] Call Trace: [ 84.791054] csum_partial+0xd/0x20 [ 84.791657] gre_gso_segment+0x2c3/0x390 [ 84.792364] inet_gso_segment+0x161/0x3e0 [ 84.793071] skb_mac_gso_segment+0xb8/0x120 [ 84.793846] __skb_gso_segment+0x7e/0x180 [ 84.794581] validate_xmit_skb+0x141/0x2e0 [ 84.795297] __dev_queue_xmit+0x258/0x8f0 [ 84.795949] ? eth_header+0x26/0xc0 [ 84.796581] ip_finish_output2+0x196/0x430 [ 84.797295] ? skb_gso_validate_network_len+0x11/0x80 [ 84.798183] ? ip_finish_output+0x169/0x270 [ 84.798875] ip_output+0x6c/0xe0 [ 84.799413] ? ip_append_data.part.50+0xc0/0xc0 [ 84.800145] iptunnel_xmit+0x144/0x1c0 [ 84.800814] ip_tunnel_xmit+0x62d/0x930 [ip_tunnel] [ 84.801699] gre_tap_xmit+0xac/0xf0 [ip_gre] [ 84.802395] dev_hard_start_xmit+0xa5/0x210 [ 84.803086] sch_direct_xmit+0x14f/0x340 [ 84.803733] __dev_queue_xmit+0x799/0x8f0 [ 84.804472] ip_finish_output2+0x2e0/0x430 [ 84.805255] ? skb_gso_validate_network_len+0x11/0x80 [ 84.806154] ip_output+0x6c/0xe0 [ 84.806721] ? ip_append_data.part.50+0xc0/0xc0 [ 84.807516] sctp_packet_transmit+0x716/0xa10 [sctp] [ 84.808337] sctp_outq_flush+0xd7/0x880 [sctp] It was caused by SKB_GSO_CB(skb)->csum_start not set in sctp_gso_segment. sctp_gso_segment() calls skb_segment() with 'feature | NETIF_F_HW_CSUM', which causes SKB_GSO_CB(skb)->csum_start not to be set in skb_segment(). For TCP/UDP, when feature supports HW_CSUM, CHECKSUM_PARTIAL will be set and gso_reset_checksum will be called to set SKB_GSO_CB(skb)->csum_start. So SCTP should do the same as TCP/UDP, to call gso_reset_checksum() when computing checksum in sctp_gso_segment. Reported-by: Jianlin Shi <jishi@redhat.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-02-27 10:07:01 +01:00
..
associola.c	sctp: clear the transport of some out_chunk_list chunks in sctp_assoc_rm_peer	2018-12-01 09:44:19 +01:00
auth.c	sctp: use IS_ENABLED() instead of checking for built-in or module	2016-09-10 21:19:11 -07:00
bind_addr.c	sctp: fix copying more bytes than expected in sctp_add_bind_addr	2016-03-08 15:04:08 -05:00
chunk.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-10-02 22:20:41 -04:00
debug.c	net: sctp: fix array overrun read on sctp_timer_tbl	2017-12-09 22:01:53 +01:00
endpointola.c	sctp: add SCTP_PR_SUPPORTED on sctp sockopt	2016-07-11 13:25:38 -07:00
input.c	sctp: add the missing sock_owned_by_user check in sctp_icmp_redirect	2017-11-18 11:22:21 +01:00
inqueue.c	sctp: fix the issue that the cookie-ack with auth can't get processed	2018-05-19 10:26:59 +02:00
ipv6.c	sctp: allocate sctp_sockaddr_entry with kzalloc	2019-01-23 08:10:56 +01:00
Kconfig	sctp: add the sctp_diag.c file	2016-04-15 17:29:36 -04:00
Makefile	sctp: Add GSO support	2016-06-03 19:37:21 -04:00
objcnt.c	sctp: fix checkpatch errors with (foo*)|foo * bar|foo* bar	2013-12-26 13:47:47 -05:00
offload.c	sctp: call gso_reset_checksum when computing checksum in sctp_gso_segment	2019-02-27 10:07:01 +01:00
output.c	sctp: fix the panic caused by route update	2016-10-26 17:32:19 -04:00
outqueue.c	sctp: only update outstanding_bytes for transmitted queue when doing prsctp_prune	2018-02-25 11:05:47 +01:00
primitive.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
probe.c	net: sctp: Convert log timestamps to be y2038 safe	2016-03-01 17:18:44 -05:00
proc.c	sctp: hold transport before accessing its asoc in sctp_transport_get_next	2018-09-15 09:42:56 +02:00
protocol.c	sctp: allocate sctp_sockaddr_entry with kzalloc	2019-01-23 08:10:56 +01:00
sctp_diag.c	sctp: Avoid out-of-bounds reads from address storage	2017-09-20 08:19:54 +02:00
sm_make_chunk.c	sctp: verify size of a new chunk in _sctp_make_chunk()	2018-03-11 16:21:34 +01:00
sm_sideeffect.c	sctp: make sctp_outq_flush/tail/uncork return void	2016-09-18 22:02:33 -04:00
sm_statefuns.c	sctp: delay the authentication for the duplicated cookie-echo chunk	2018-05-19 10:26:59 +02:00
sm_statetable.c	sctp: fix checkpatch errors with indent	2013-12-26 13:47:48 -05:00
socket.c	sctp: not allow to set asoc prsctp_enable by sockopt	2018-11-23 08:20:34 +01:00
ssnmap.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
sysctl.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-01-11 23:55:43 -05:00
transport.c	sctp: not allow transport timeout value less than HZ/5 for hb_timer	2018-06-13 16:16:43 +02:00
tsnmap.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
ulpevent.c	sctp: remove sctp_chunk_put from fail_mark err path in sctp_ulpevent_make_rcvmsg	2018-05-19 10:26:58 +02:00
ulpqueue.c	sctp: fix missing wake ups in some situations	2017-09-20 08:19:56 +02:00