Junxiao Bi 44ae7181db ocfs2: fix ocfs2 read block panic ... commit 234b69e3e0 upstream. While reading block, it is possible that io error return due to underlying storage issue, in this case, BH_NeedsValidate was left in the buffer head. Then when reading the very block next time, if it was already linked into journal, that will trigger the following panic. [203748.702517] kernel BUG at fs/ocfs2/buffer_head_io.c:342! [203748.702533] invalid opcode: 0000 [#1] SMP [203748.702561] Modules linked in: ocfs2 ocfs2_dlmfs ocfs2_stack_o2cb ocfs2_dlm ocfs2_nodemanager ocfs2_stackglue configfs sunrpc dm_switch dm_queue_length dm_multipath bonding be2iscsi iscsi_boot_sysfs bnx2i cnic uio cxgb4i iw_cxgb4 cxgb4 cxgb3i libcxgbi iw_cxgb3 cxgb3 mdio ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_core ib_addr ipv6 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi ipmi_devintf iTCO_wdt iTCO_vendor_support dcdbas ipmi_ssif i2c_core ipmi_si ipmi_msghandler acpi_pad pcspkr sb_edac edac_core lpc_ich mfd_core shpchp sg tg3 ptp pps_core ext4 jbd2 mbcache2 sr_mod cdrom sd_mod ahci libahci megaraid_sas wmi dm_mirror dm_region_hash dm_log dm_mod [203748.703024] CPU: 7 PID: 38369 Comm: touch Not tainted 4.1.12-124.18.6.el6uek.x86_64 #2 [203748.703045] Hardware name: Dell Inc. PowerEdge R620/0PXXHP, BIOS 2.5.2 01/28/2015 [203748.703067] task: ffff880768139c00 ti: ffff88006ff48000 task.ti: ffff88006ff48000 [203748.703088] RIP: 0010:[<ffffffffa05e9f09>] [<ffffffffa05e9f09>] ocfs2_read_blocks+0x669/0x7f0 [ocfs2] [203748.703130] RSP: 0018:ffff88006ff4b818 EFLAGS: 00010206 [203748.703389] RAX: 0000000008620029 RBX: ffff88006ff4b910 RCX: 0000000000000000 [203748.703885] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 00000000023079fe [203748.704382] RBP: ffff88006ff4b8d8 R08: 0000000000000000 R09: ffff8807578c25b0 [203748.704877] R10: 000000000f637376 R11: 000000003030322e R12: 0000000000000000 [203748.705373] R13: ffff88006ff4b910 R14: ffff880732fe38f0 R15: 0000000000000000 [203748.705871] FS: 00007f401992c700(0000) GS:ffff880bfebc0000(0000) knlGS:0000000000000000 [203748.706370] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [203748.706627] CR2: 00007f4019252440 CR3: 00000000a621e000 CR4: 0000000000060670 [203748.707124] Stack: [203748.707371] ffff88006ff4b828 ffffffffa0609f52 ffff88006ff4b838 0000000000000001 [203748.707885] 0000000000000000 0000000000000000 ffff880bf67c3800 ffffffffa05eca00 [203748.708399] 00000000023079ff ffffffff81c58b80 0000000000000000 0000000000000000 [203748.708915] Call Trace: [203748.709175] [<ffffffffa0609f52>] ? ocfs2_inode_cache_io_unlock+0x12/0x20 [ocfs2] [203748.709680] [<ffffffffa05eca00>] ? ocfs2_empty_dir_filldir+0x80/0x80 [ocfs2] [203748.710185] [<ffffffffa05ec0cb>] ocfs2_read_dir_block_direct+0x3b/0x200 [ocfs2] [203748.710691] [<ffffffffa05f0fbf>] ocfs2_prepare_dx_dir_for_insert.isra.57+0x19f/0xf60 [ocfs2] [203748.711204] [<ffffffffa065660f>] ? ocfs2_metadata_cache_io_unlock+0x1f/0x30 [ocfs2] [203748.711716] [<ffffffffa05f4f3a>] ocfs2_prepare_dir_for_insert+0x13a/0x890 [ocfs2] [203748.712227] [<ffffffffa05f442e>] ? ocfs2_check_dir_for_entry+0x8e/0x140 [ocfs2] [203748.712737] [<ffffffffa061b2f2>] ocfs2_mknod+0x4b2/0x1370 [ocfs2] [203748.713003] [<ffffffffa061c385>] ocfs2_create+0x65/0x170 [ocfs2] [203748.713263] [<ffffffff8121714b>] vfs_create+0xdb/0x150 [203748.713518] [<ffffffff8121b225>] do_last+0x815/0x1210 [203748.713772] [<ffffffff812192e9>] ? path_init+0xb9/0x450 [203748.714123] [<ffffffff8121bca0>] path_openat+0x80/0x600 [203748.714378] [<ffffffff811bcd45>] ? handle_pte_fault+0xd15/0x1620 [203748.714634] [<ffffffff8121d7ba>] do_filp_open+0x3a/0xb0 [203748.714888] [<ffffffff8122a767>] ? __alloc_fd+0xa7/0x130 [203748.715143] [<ffffffff81209ffc>] do_sys_open+0x12c/0x220 [203748.715403] [<ffffffff81026ddb>] ? syscall_trace_enter_phase1+0x11b/0x180 [203748.715668] [<ffffffff816f0c9f>] ? system_call_after_swapgs+0xe9/0x190 [203748.715928] [<ffffffff8120a10e>] SyS_open+0x1e/0x20 [203748.716184] [<ffffffff816f0d5e>] system_call_fastpath+0x18/0xd7 [203748.716440] Code: 00 00 48 8b 7b 08 48 83 c3 10 45 89 f8 44 89 e1 44 89 f2 4c 89 ee e8 07 06 11 e1 48 8b 03 48 85 c0 75 df 8b 5d c8 e9 4d fa ff ff <0f> 0b 48 8b 7d a0 e8 dc c6 06 00 48 b8 00 00 00 00 00 00 00 10 [203748.717505] RIP [<ffffffffa05e9f09>] ocfs2_read_blocks+0x669/0x7f0 [ocfs2] [203748.717775] RSP <ffff88006ff4b818> Joesph ever reported a similar panic. Link: https://oss.oracle.com/pipermail/ocfs2-devel/2013-May/008931.html Link: http://lkml.kernel.org/r/20180912063207.29484-1-junxiao.bi@oracle.com Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com> Cc: Joseph Qi <jiangqi903@gmail.com> Cc: Mark Fasheh <mark@fasheh.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Changwei Ge <ge.changwei@h3c.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-09-29 03:07:33 -07:00
..
cluster	ocfs2: subsystem.su_mutex is required while accessing the item->ci_parent	2018-07-22 14:27:35 +02:00
dlm	ocfs2/dlm: don't handle migrate lockres if already in shutdown	2018-05-30 07:50:41 +02:00
dlmfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
acl.c	ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute	2018-05-30 07:50:23 +02:00
acl.h	ocfs2: fix posix_acl_create deadlock	2016-05-12 15:52:50 -07:00
alloc.c	ocfs2: fstrim: Fix start offset of first cluster group during fstrim	2017-11-08 10:08:32 +01:00
alloc.h	ocfs2: retry on ENOSPC if sufficient space in truncate log	2016-08-02 17:31:41 -04:00
aops.c	ocfs2: ip_alloc_sem should be taken in ocfs2_get_block()	2018-07-22 14:27:35 +02:00
aops.h	ocfs2: fix ip_unaligned_aio deadlock with dio work queue	2016-03-25 16:37:42 -07:00
blockcheck.c	ocfs2: kill endianness abuses in blockcheck.c	2012-05-29 23:28:35 -04:00
blockcheck.h
buffer_head_io.c	ocfs2: fix ocfs2 read block panic	2018-09-29 03:07:33 -07:00
buffer_head_io.h
dcache.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dcache.h	ocfs2: revert iput deferring code in ocfs2_drop_dentry_lock	2014-04-03 16:20:55 -07:00
dir.c	ocfs2: fix not enough credit panic	2016-11-11 08:12:37 -08:00
dir.h	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dlmglue.c	ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE	2018-02-22 15:43:52 +01:00
dlmglue.h	ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock	2017-10-21 17:21:36 +02:00
export.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
export.h
extent_map.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
extent_map.h	ocfs2: Implement llseek()	2011-07-25 14:58:15 -07:00
file.c	ocfs2: should wait dio before inode lock in ocfs2_setattr()	2017-11-24 08:33:42 +01:00
file.h	ocfs2: prepare some interfaces used in append direct io	2015-02-16 17:56:04 -08:00
filecheck.c	ocfs2: sysfile interfaces for online file check	2016-03-22 15:36:02 -07:00
filecheck.h	ocfs2: sysfile interfaces for online file check	2016-03-22 15:36:02 -07:00
heartbeat.c	ocfs2: Remove mlog(0) from fs/ocfs2/heartbeat.c	2011-02-23 21:17:39 +08:00
heartbeat.h
inode.c	ocfs2: fix improper handling of return errno	2016-05-26 15:35:44 -07:00
inode.h	ocfs2: fix undefined struct variable in inode.h	2016-10-07 18:46:26 -07:00
ioctl.c	wrappers for ->i_mutex access	2016-01-22 18:04:28 -05:00
ioctl.h
journal.c	ocfs2: return error when we attempt to access a dirty bh in jbd2	2018-05-30 07:50:23 +02:00
journal.h	jbd2: add support for avoiding data writes during transaction commits	2016-04-24 00:56:07 -04:00
Kconfig
localalloc.c	ocfs2: fix occurring deadlock by changing ocfs2_wq from global to local	2016-03-25 16:37:42 -07:00
localalloc.h	ocfs2: free allocated clusters if error occurs after ocfs2_claim_clusters	2014-02-06 13:48:51 -08:00
locks.c	ocfs2: fix flock panic issue	2015-12-29 17:45:49 -08:00
locks.h
Makefile	ocfs2: disable BUG assertions in reading blocks	2016-06-24 17:23:52 -07:00
mmap.c	mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros	2016-04-04 10:41:08 -07:00
mmap.h
move_extents.c	fs: Replace CURRENT_TIME with current_time() for inode timestamps	2016-09-27 21:06:21 -04:00
move_extents.h	Ocfs2/move_extents: move/defrag extents within a certain range.	2011-05-25 15:17:12 +08:00
namei.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-10 20:16:43 -07:00
namei.h	ocfs2: do not include dio entry in case of orphan scan	2015-11-05 19:34:48 -08:00
ocfs1_fs_compat.h
ocfs2_fs.h	ocfs2: fix comment in struct ocfs2_extended_slot	2016-05-19 19:12:14 -07:00
ocfs2_ioctl.h	Ocfs2/move_extents: Adding new ioctl code 'OCFS2_IOC_MOVE_EXT' to ocfs2.	2011-05-25 15:17:08 +08:00
ocfs2_lockid.h
ocfs2_lockingver.h
ocfs2_trace.h	switch generic_file_splice_read() to use of ->read_iter()	2016-10-05 18:23:56 -04:00
ocfs2.h	ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock	2017-10-21 17:21:36 +02:00
quota_global.c	quota: use time64_t internally	2016-06-19 18:09:31 +02:00
quota_local.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
quota.h	quota: constify qtree_fmt_operations structures	2016-01-04 10:58:35 +01:00
refcounttree.c	fs: Replace CURRENT_TIME with current_time() for inode timestamps	2016-09-27 21:06:21 -04:00
refcounttree.h	ocfs2: fix NULL pointer dereference in ocfs2_duplicate_clusters_by_page	2013-08-13 17:57:49 -07:00
reservations.c	ocfs2: make resv_lock spinlock static	2015-02-10 14:30:29 -08:00
reservations.h	Fix common misspellings	2011-03-31 11:26:23 -03:00
resize.c	ocfs2: solve a problem of crossing the boundary in updating backups	2016-03-25 16:37:42 -07:00
resize.h
slot_map.c	ocfs2: clean up an unneeded goto in ocfs2_put_slot()	2016-05-19 19:12:14 -07:00
slot_map.h
stack_o2cb.c	ocfs2: avoid a pointless delay in o2cb_cluster_check()	2015-04-14 16:48:57 -07:00
stack_user.c	ocfs2: ensure that dlm lockspace is created by kernel module	2016-08-02 17:31:41 -04:00
stackglue.c	ocfs2: fix crash caused by stale lvb with fsdlm plugin	2017-01-19 20:17:59 +01:00
stackglue.h	ocfs2: fix crash caused by stale lvb with fsdlm plugin	2017-01-19 20:17:59 +01:00
suballoc.c	ocfs2: fix double unlock in case retry after free truncate log	2016-09-19 15:36:17 -07:00
suballoc.h	ocfs2: rollback alloc_dinode counts when ocfs2_block_group_set_bits() failed	2014-04-03 16:20:56 -07:00
super.c	ocfs2: return -EROFS to mount.ocfs2 if inode block is invalid	2018-05-30 07:50:22 +02:00
super.h	ocfs2: fix occurring deadlock by changing ocfs2_wq from global to local	2016-03-25 16:37:42 -07:00
symlink.c	vfs: Remove {get,set,remove}xattr inode operations	2016-10-07 21:48:36 -04:00
symlink.h	ocfs: simplify symlink handling	2012-05-29 23:28:40 -04:00
sysfile.c	ocfs2: avoid system inode ref confusion by adding mutex lock	2014-04-03 16:20:57 -07:00
sysfile.h
uptodate.c	ocfs2: remove NULL assignments on static	2014-06-04 16:53:53 -07:00
uptodate.h
xattr.c	ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute	2018-05-30 07:50:23 +02:00
xattr.h	ocfs2: fix posix_acl_create deadlock	2016-05-12 15:52:50 -07:00