linux-brain/drivers/usb
Nathan Chancellor bfde821e78 usb: gadget: udc: bdc: Remove unnecessary NULL checks in bdc_req_complete
commit 09b04abb70f096333bef6bc95fa600b662e7ee13 upstream.

When building with Clang + -Wtautological-pointer-compare:

drivers/usb/gadget/udc/bdc/bdc_ep.c:543:28: warning: comparison of
address of 'req->queue' equal to a null pointer is always false
[-Wtautological-pointer-compare]
        if (req == NULL  || &req->queue == NULL || &req->usb_req == NULL)
                             ~~~~~^~~~~    ~~~~
drivers/usb/gadget/udc/bdc/bdc_ep.c:543:51: warning: comparison of
address of 'req->usb_req' equal to a null pointer is always false
[-Wtautological-pointer-compare]
        if (req == NULL  || &req->queue == NULL || &req->usb_req == NULL)
                                                    ~~~~~^~~~~~~    ~~~~
2 warnings generated.

As it notes, these statements will always evaluate to false so remove
them.

Fixes: efed421a94 ("usb: gadget: Add UDC driver for Broadcom USB3.0 device controller IP BDC")
Link: https://github.com/ClangBuiltLinux/linux/issues/749
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-05-02 17:25:49 +02:00
..
atm USB: atm: ueagle-atm: add missing endpoint check 2019-12-17 20:34:37 +01:00
c67x00 USB: add SPDX identifiers to all remaining Makefiles 2017-11-07 15:53:48 +01:00
chipidea usb: chipidea: host: Disable port power only if previously enabled 2020-01-14 20:06:58 +01:00
class cdc-acm: introduce a cool down 2020-04-29 16:31:33 +02:00
common usb: common: Consider only available nodes for dr_mode 2019-04-03 06:26:27 +02:00
core USB: hub: Fix handling of connect changes during sleep 2020-04-29 16:31:27 +02:00
dwc2 usb: dwc2: Fix in ISOC request length checking 2020-02-28 16:38:59 +01:00
dwc3 usb: dwc3: gadget: Do link recovery for SS and SSP 2020-05-02 17:25:48 +02:00
early USB: early: Handle AMD's spec-compliant identifiers, too 2020-04-29 16:31:26 +02:00
gadget usb: gadget: udc: bdc: Remove unnecessary NULL checks in bdc_req_complete 2020-05-02 17:25:49 +02:00
host xhci: prevent bus suspend if a roothub port detected a over-current condition 2020-04-29 16:31:34 +02:00
image USB: microtek: fix info-leak at probe 2019-10-17 13:45:05 -07:00
isp1760 usb: isp1760: remove redundant variable 'selector' 2018-07-13 15:41:56 +02:00
misc USB: sisusbvga: Change port variable from signed to unsigned 2020-04-29 16:31:26 +02:00
mon usb: mon: Fix a deadlock in usbmon between mmap and read 2019-12-17 20:34:41 +01:00
mtu3 usb: mtu3: fix dbginfo in qmu_tx_zlp_error_handler 2019-12-13 08:52:32 +01:00
musb usb: musb: fix crash with highmen PIO and usbmon 2020-04-02 15:28:20 +02:00
phy usb: gadget: fsl: fix link error against usb-gadget module 2020-01-27 14:50:43 +01:00
renesas_usbhs usb: renesas_usbhs: add suspend event support in gadget mode 2019-12-31 16:34:54 +01:00
roles usb: roles: fix a potential use after free 2019-12-17 20:34:39 +01:00
serial USB: serial: io_edgeport: fix slab-out-of-bounds read in edge_interrupt_callback 2020-04-02 15:28:20 +02:00
storage UAS: fix deadlock in error handling and PM flushing work 2020-04-29 16:31:34 +02:00
typec usb: typec: tcpci: mask event interrupts when remove driver 2020-02-11 04:33:55 -08:00
usbip usbip: Fix error path of vhci_recv_ret_submit() 2019-12-31 16:36:21 +01:00
wusbcore usb: wusbcore: security: cast sizeof to int for comparison 2018-07-02 18:08:19 +02:00
Kconfig usb: roles: Add a description for the class to Kconfig 2019-01-09 17:38:40 +01:00
Makefile usb: roles: Add Intel xHCI USB role switch driver 2018-03-22 13:49:27 +01:00
README
usb-skeleton.c USB: usb-skeleton: fix NULL-deref on disconnect 2019-10-17 13:44:50 -07:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("hub_wq").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.