Darrick J. Wong e8bf3395eb ocfs2: fix inode bh swapping mixup in ocfs2_reflink_inodes_lock ... commit e6a9467ea1 upstream. ocfs2_reflink_inodes_lock() can swap the inode1/inode2 variables so that we always grab cluster locks in order of increasing inode number. Unfortunately, we forget to swap the inode record buffer head pointers when we've done this, which leads to incorrect bookkeepping when we're trying to make the two inodes have the same refcount tree. This has the effect of causing filesystem shutdowns if you're trying to reflink data from inode 100 into inode 97, where inode 100 already has a refcount tree attached and inode 97 doesn't. The reflink code decides to copy the refcount tree pointer from 100 to 97, but uses inode 97's inode record to open the tree root (which it doesn't have) and blows up. This issue causes filesystem shutdowns and metadata corruption! Link: http://lkml.kernel.org/r/20190312214910.GK20533@magnolia Fixes: 29ac8e856c ("ocfs2: implement the VFS clone_range, copy_range, and dedupe_range features") Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Joseph Qi <jiangqi903@gmail.com> Cc: Mark Fasheh <mfasheh@versity.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Joseph Qi <joseph.qi@huawei.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-04-03 06:25:17 +02:00
..
cluster	ocfs2: free up write context when direct IO failed	2018-11-21 09:24:09 +01:00
dlm	ocfs2: improve ocfs2 Makefile	2019-02-12 19:46:09 +01:00
dlmfs	ocfs2: improve ocfs2 Makefile	2019-02-12 19:46:09 +01:00
acl.c	ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute	2018-04-26 11:02:14 +02:00
acl.h	ocfs2: make ocfs2_set_acl() static	2017-09-06 17:27:24 -07:00
alloc.c	ocfs2: fstrim: Fix start offset of first cluster group during fstrim	2017-11-03 07:39:19 -07:00
alloc.h	ocfs2: clean up some dead code	2017-09-06 17:27:24 -07:00
aops.c	ocfs2: free up write context when direct IO failed	2018-11-21 09:24:09 +01:00
aops.h	ocfs2: clean up unused 'page' parameter in ocfs2_write_end_nolock()	2016-12-12 18:55:06 -08:00
blockcheck.c	ocfs2: kill endianness abuses in blockcheck.c	2012-05-29 23:28:35 -04:00
blockcheck.h
buffer_head_io.c	ocfs2: don't clear bh uptodate for block read	2019-02-12 19:46:09 +01:00
buffer_head_io.h
dcache.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dcache.h	ocfs2: revert iput deferring code in ocfs2_drop_dentry_lock	2014-04-03 16:20:55 -07:00
dir.c	ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry	2018-11-21 09:24:09 +01:00
dir.h	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dlmglue.c	ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE	2018-02-22 15:42:16 +01:00
dlmglue.h	ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock	2017-02-22 16:41:27 -08:00
export.c	ocfs2: fix potential use after free	2018-12-17 09:28:54 +01:00
export.h
extent_map.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
extent_map.h
file.c	ocfs2: should wait dio before inode lock in ocfs2_setattr()	2017-11-24 08:37:04 +01:00
file.h	statx: Add a system call to make enhanced file info available	2017-03-02 20:51:15 -05:00
filecheck.c	ocfs2: sysfile interfaces for online file check	2016-03-22 15:36:02 -07:00
filecheck.h	ocfs2: sysfile interfaces for online file check	2016-03-22 15:36:02 -07:00
heartbeat.c
heartbeat.h
inode.c	ocfs2: fix a static checker warning	2017-07-06 16:24:30 -07:00
inode.h	ocfs2: convert inode refcount test to a helper	2016-12-10 12:39:45 -08:00
ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ioctl.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
journal.c	ocfs2: return error when we attempt to access a dirty bh in jbd2	2018-04-26 11:02:14 +02:00
journal.h	jbd2: add support for avoiding data writes during transaction commits	2016-04-24 00:56:07 -04:00
Kconfig
localalloc.c	ocfs2: fix panic due to unrecovered local alloc	2019-01-26 09:37:06 +01:00
localalloc.h	ocfs2: free allocated clusters if error occurs after ocfs2_claim_clusters	2014-02-06 13:48:51 -08:00
locks.c	ocfs2: fix flock panic issue	2015-12-29 17:45:49 -08:00
locks.h
Makefile	ocfs2: improve ocfs2 Makefile	2019-02-12 19:46:09 +01:00
mmap.c	mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf	2017-02-24 17:46:54 -08:00
mmap.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
move_extents.c	ocfs2: fix deadlock caused by ocfs2_defrag_extent()	2018-12-17 09:28:54 +01:00
move_extents.h
namei.c	ocfs2: replace CURRENT_TIME macro	2016-12-12 18:55:06 -08:00
namei.h	ocfs2: do not include dio entry in case of orphan scan	2015-11-05 19:34:48 -08:00
ocfs1_fs_compat.h
ocfs2_fs.h	ocfs2: use magic.h	2017-07-06 16:24:30 -07:00
ocfs2_ioctl.h
ocfs2_lockid.h
ocfs2_lockingver.h
ocfs2_trace.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ocfs2.h	ocfs2: clean up some dead code	2017-09-06 17:27:24 -07:00
quota_global.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
quota_local.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
quota.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
refcounttree.c	ocfs2: fix inode bh swapping mixup in ocfs2_reflink_inodes_lock	2019-04-03 06:25:17 +02:00
refcounttree.h	ocfs2: implement the VFS clone_range, copy_range, and dedupe_range features	2016-12-10 12:39:45 -08:00
reservations.c	ocfs2: make resv_lock spinlock static	2015-02-10 14:30:29 -08:00
reservations.h
resize.c	ocfs2: solve a problem of crossing the boundary in updating backups	2016-03-25 16:37:42 -07:00
resize.h
slot_map.c	ocfs2: clean up an unneeded goto in ocfs2_put_slot()	2016-05-19 19:12:14 -07:00
slot_map.h
stack_o2cb.c	ocfs2: avoid a pointless delay in o2cb_cluster_check()	2015-04-14 16:48:57 -07:00
stack_user.c	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
stackglue.c	ocfs2: constify attribute_group structures	2017-07-06 16:24:30 -07:00
stackglue.h	ocfs2: fix crash caused by stale lvb with fsdlm plugin	2017-01-10 18:31:54 -08:00
suballoc.c	ocfs2: clean up some dead code	2017-09-06 17:27:24 -07:00
suballoc.h	ocfs2: rollback alloc_dinode counts when ocfs2_block_group_set_bits() failed	2014-04-03 16:20:56 -07:00
super.c	ocfs2: return -EROFS to mount.ocfs2 if inode block is invalid	2018-04-26 11:02:14 +02:00
super.h	ocfs2: fix occurring deadlock by changing ocfs2_wq from global to local	2016-03-25 16:37:42 -07:00
symlink.c	vfs: remove ".readlink = generic_readlink" assignments	2016-12-09 16:45:04 +01:00
symlink.h	ocfs: simplify symlink handling	2012-05-29 23:28:40 -04:00
sysfile.c	ocfs2: avoid system inode ref confusion by adding mutex lock	2014-04-03 16:20:57 -07:00
sysfile.h
uptodate.c	ocfs2: remove NULL assignments on static	2014-06-04 16:53:53 -07:00
uptodate.h
xattr.c	ocfs2/acl: use 'ip_xattr_sem' to protect getting extended attribute	2018-04-26 11:02:14 +02:00
xattr.h	ocfs2: fix posix_acl_create deadlock	2016-05-12 15:52:50 -07:00