mirror of
https://github.com/brain-hackers/linux-brain.git
synced 2024-06-09 15:26:21 +09:00
sfp: Fix error handing in sfp_probe()
[ Upstream commit 9621618130bf7e83635367c13b9a6ee53935bb37 ]
gpiod_to_irq() never return 0, but returns negative in
case of error, check it and set gpio_irq to 0.
Fixes: 7397005545
("sfp: add SFP module support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20201031031053.25264-1-yuehaibing@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
9b5458effe
commit
e5ea79bb19
|
@ -1970,7 +1970,8 @@ static int sfp_probe(struct platform_device *pdev)
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
sfp->gpio_irq[i] = gpiod_to_irq(sfp->gpio[i]);
|
sfp->gpio_irq[i] = gpiod_to_irq(sfp->gpio[i]);
|
||||||
if (!sfp->gpio_irq[i]) {
|
if (sfp->gpio_irq[i] < 0) {
|
||||||
|
sfp->gpio_irq[i] = 0;
|
||||||
poll = true;
|
poll = true;
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue
Block a user