mirror of
https://github.com/brain-hackers/linux-brain.git
synced 2024-06-09 23:36:23 +09:00
dccp: Fix memleak in __feat_register_sp
commit1d3ff0950e
upstream. If dccp_feat_push_change fails, we forget free the mem which is alloced by kmemdup in dccp_feat_clone_sp_val. Reported-by: Hulk Robot <hulkci@huawei.com> Fixes:e8ef967a54
("dccp: Registration routines for changing feature values") Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
db1fb5a397
commit
d0c15c1e8f
|
@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
|
|||
if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
|
||||
return -ENOMEM;
|
||||
|
||||
return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
|
||||
if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
|
||||
kfree(fval.sp.vec);
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
Loading…
Reference in New Issue
Block a user