From e1195cca2a4ff06378e3775536688b63cd004dd9 Mon Sep 17 00:00:00 2001
From: Suguru Saito <sg.sgch07@gmail.com>
Date: Sun, 3 Oct 2021 20:48:29 +0900
Subject: [PATCH 1/5] spi: spi-mxs: add support 9-16 bits per word transfer

---
 drivers/spi/spi-mxs.c | 45 ++++++++++++++++++++++++++++++++++---------
 1 file changed, 36 insertions(+), 9 deletions(-)

diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c
index 34856c9ad931..7939fd06c0cf 100644
--- a/drivers/spi/spi-mxs.c
+++ b/drivers/spi/spi-mxs.c
@@ -68,6 +68,13 @@ static int mxs_spi_setup_transfer(struct spi_device *dev,
 	struct mxs_ssp *ssp = &spi->ssp;
 	const unsigned int hz = min(dev->max_speed_hz, t->speed_hz);
 
+	if (t->bits_per_word > 8) {
+		if (t->len & 1) {
+			dev_err(&dev->dev, "Invalid size of rx and tx buffers\n");
+			return -EINVAL;
+		}
+	}
+
 	if (hz == 0) {
 		dev_err(&dev->dev, "SPI clock rate of zero not allowed\n");
 		return -EINVAL;
@@ -91,7 +98,7 @@ static int mxs_spi_setup_transfer(struct spi_device *dev,
 		ssp->base + HW_SSP_CTRL0 + STMP_OFFSET_REG_SET);
 
 	writel(BF_SSP_CTRL1_SSP_MODE(BV_SSP_CTRL1_SSP_MODE__SPI) |
-	       BF_SSP_CTRL1_WORD_LENGTH(BV_SSP_CTRL1_WORD_LENGTH__EIGHT_BITS) |
+	       BF_SSP_CTRL1_WORD_LENGTH(t->bits_per_word - 1) |
 	       ((dev->mode & SPI_CPOL) ? BM_SSP_CTRL1_POLARITY : 0) |
 	       ((dev->mode & SPI_CPHA) ? BM_SSP_CTRL1_PHASE : 0),
 	       ssp->base + HW_SSP_CTRL1(ssp));
@@ -297,14 +304,18 @@ err_mapped:
 }
 
 static int mxs_spi_txrx_pio(struct mxs_spi *spi,
-			    unsigned char *buf, int len,
+			    unsigned char *buf, int len, u8 bit_per_word,
 			    unsigned int flags)
 {
 	struct mxs_ssp *ssp = &spi->ssp;
+	u32 val;
 
 	writel(BM_SSP_CTRL0_IGNORE_CRC,
 	       ssp->base + HW_SSP_CTRL0 + STMP_OFFSET_REG_CLR);
 
+	if (bit_per_word > 8)
+		len /= 2;
+
 	while (len--) {
 		if (len == 0 && (flags & TXRX_DEASSERT_CS))
 			writel(BM_SSP_CTRL0_IGNORE_CRC,
@@ -332,8 +343,14 @@ static int mxs_spi_txrx_pio(struct mxs_spi *spi,
 		if (mxs_ssp_wait(spi, HW_SSP_CTRL0, BM_SSP_CTRL0_RUN, 1))
 			return -ETIMEDOUT;
 
-		if (flags & TXRX_WRITE)
-			writel(*buf, ssp->base + HW_SSP_DATA(ssp));
+		if (flags & TXRX_WRITE) {
+			if (bit_per_word > 8)
+				val = *(u16*)(buf);
+			else
+				val = *buf;
+
+			writel(val, ssp->base + HW_SSP_DATA(ssp));
+		}
 
 		writel(BM_SSP_CTRL0_DATA_XFER,
 			     ssp->base + HW_SSP_CTRL0 + STMP_OFFSET_REG_SET);
@@ -343,13 +360,21 @@ static int mxs_spi_txrx_pio(struct mxs_spi *spi,
 						BM_SSP_STATUS_FIFO_EMPTY, 0))
 				return -ETIMEDOUT;
 
-			*buf = (readl(ssp->base + HW_SSP_DATA(ssp)) & 0xff);
+			val = readl(ssp->base + HW_SSP_DATA(ssp));
+
+			if (bit_per_word > 8)
+				*(u16*)buf = val & ((1 << bit_per_word) - 1);
+			else
+				*buf = val & 0xff;
 		}
 
 		if (mxs_ssp_wait(spi, HW_SSP_CTRL0, BM_SSP_CTRL0_RUN, 0))
 			return -ETIMEDOUT;
 
-		buf++;
+		if (bit_per_word > 8)
+			buf += 2;
+		else
+			buf++;
 	}
 
 	if (len <= 0)
@@ -401,11 +426,13 @@ static int mxs_spi_transfer_one(struct spi_master *master,
 
 			if (t->tx_buf)
 				status = mxs_spi_txrx_pio(spi,
-						(void *)t->tx_buf,
-						t->len, flag | TXRX_WRITE);
+						(void *)t->tx_buf, t->len,
+						t->bits_per_word,
+						flag | TXRX_WRITE);
 			if (t->rx_buf)
 				status = mxs_spi_txrx_pio(spi,
 						t->rx_buf, t->len,
+						t->bits_per_word,
 						flag);
 		} else {
 			writel(BM_SSP_CTRL1_DMA_ENABLE,
@@ -569,7 +596,7 @@ static int mxs_spi_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, master);
 
 	master->transfer_one_message = mxs_spi_transfer_one;
-	master->bits_per_word_mask = SPI_BPW_MASK(8);
+	master->bits_per_word_mask = SPI_BPW_RANGE_MASK(8, 16);
 	master->mode_bits = SPI_CPOL | SPI_CPHA;
 	master->num_chipselect = 3;
 	master->dev.of_node = np;

From eecf83c04c26cb9d4cb486409fac418fe1dde2f0 Mon Sep 17 00:00:00 2001
From: Suguru Saito <sg.sgch07@gmail.com>
Date: Sun, 3 Oct 2021 20:52:12 +0900
Subject: [PATCH 2/5] drm: add support Sharp Brain 2nd generation SubLCD

---
 drivers/gpu/drm/tiny/Kconfig  | 12 ++++++++++++
 drivers/gpu/drm/tiny/Makefile |  1 +
 2 files changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
index d093083595d7..5b30e205105d 100644
--- a/drivers/gpu/drm/tiny/Kconfig
+++ b/drivers/gpu/drm/tiny/Kconfig
@@ -108,6 +108,18 @@ config TINYDRM_ST7586
 
 	  If M is selected the module will be called st7586.
 
+config TINYDRM_BRAIN_ST7586
+	tristate "DRM support for Sitronix ST7586 display panels on Sharp Brain"
+	depends on DRM && SPI
+	select DRM_KMS_HELPER
+	select DRM_KMS_CMA_HELPER
+	select DRM_MIPI_DBI
+	help
+	  DRM driver for the following Sitronix ST7586 panels:
+	  * Sharp Brain 240x120 LCD
+
+	  If M is selected the module will be called brain-st7586.
+
 config TINYDRM_ST7735R
 	tristate "DRM support for Sitronix ST7735R display panels"
 	depends on DRM && SPI
diff --git a/drivers/gpu/drm/tiny/Makefile b/drivers/gpu/drm/tiny/Makefile
index a7c1962c6564..2712edeeab11 100644
--- a/drivers/gpu/drm/tiny/Makefile
+++ b/drivers/gpu/drm/tiny/Makefile
@@ -9,4 +9,5 @@ obj-$(CONFIG_TINYDRM_BRAIN_2G)		+= brain-lq050j1ug01.o
 obj-$(CONFIG_TINYDRM_MI0283QT)		+= mi0283qt.o
 obj-$(CONFIG_TINYDRM_REPAPER)		+= repaper.o
 obj-$(CONFIG_TINYDRM_ST7586)		+= st7586.o
+obj-$(CONFIG_TINYDRM_BRAIN_ST7586)		+= brain-st7586.o
 obj-$(CONFIG_TINYDRM_ST7735R)		+= st7735r.o

From e90722da178abfe77f5734f30f336280aa8d73a9 Mon Sep 17 00:00:00 2001
From: Suguru Saito <sg.sgch07@gmail.com>
Date: Sun, 3 Oct 2021 20:53:18 +0900
Subject: [PATCH 3/5] arm: brain: add SubLCD support for 2nd generation

---
 arch/arm/boot/dts/imx28-brain-2g.dtsi | 29 +++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm/boot/dts/imx28-brain-2g.dtsi b/arch/arm/boot/dts/imx28-brain-2g.dtsi
index 1d89780223bf..a24d6575d4b9 100644
--- a/arch/arm/boot/dts/imx28-brain-2g.dtsi
+++ b/arch/arm/boot/dts/imx28-brain-2g.dtsi
@@ -95,6 +95,22 @@
 				status = "okay";
 			};
 
+			ssp2: spi@80014000 {
+				compatible = "fsl,imx28-spi";
+				pinctrl-names = "default";
+				pinctrl-0 = <&slcd_pins>;
+				clock-frequency = <16000000>;
+				status = "okay";
+
+				slcd@0 {
+					reg = <0>;
+					compatible = "brain,st7586";
+					spi-max-frequency = <16000000>;
+					reset-gpios = <&gpio2 18 GPIO_ACTIVE_HIGH>;
+					rotation = <180>;
+				};
+			};
+
 			pinctrl@80018000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&hog_pins_3v3_pullup &hog_pins_3v3_nopull &hog_pins_1v8_nopull>;
@@ -177,6 +193,19 @@
 					fsl,voltage = <MXS_VOLTAGE_LOW>;
 					fsl,pull-up = <MXS_PULL_DISABLE>;
 				};
+
+				slcd_pins: spi2@0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
+						MX28_PAD_SSP2_SCK__SSP2_SCK
+						MX28_PAD_SSP2_MOSI__SSP2_CMD
+						MX28_PAD_SSP2_MISO__GPIO_2_18
+						MX28_PAD_SSP2_SS0__SSP2_D3
+					>;
+					fsl,drive-strength = <MXS_DRIVE_4mA>;
+					fsl,voltage = <MXS_VOLTAGE_HIGH>;
+					fsl,pull-up = <MXS_PULL_DISABLE>;
+				};
 			};
 
 			brainlcd: lcdif@80030000 {

From 3fe5b06bcf79e9c9653c932fd636b1d6a27d0136 Mon Sep 17 00:00:00 2001
From: Suguru Saito <sg.sgch07@gmail.com>
Date: Sun, 3 Oct 2021 20:54:50 +0900
Subject: [PATCH 4/5] arm: brain: add support SubLCD backlight for 2nd
 generation

---
 arch/arm/boot/dts/imx28-brain-2g.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx28-brain-2g.dtsi b/arch/arm/boot/dts/imx28-brain-2g.dtsi
index a24d6575d4b9..3b688935bbf3 100644
--- a/arch/arm/boot/dts/imx28-brain-2g.dtsi
+++ b/arch/arm/boot/dts/imx28-brain-2g.dtsi
@@ -156,6 +156,7 @@
 					fsl,pinmux-ids = <
 						MX28_PAD_AUART1_RX__PWM_0
 						MX28_PAD_AUART1_TX__PWM_1
+						MX28_PAD_PWM2__PWM_2
 						MX28_PAD_PWM4__PWM_4
 						MX28_PAD_SAIF1_SDATA0__GPIO_3_26
 					>;
@@ -313,13 +314,20 @@
 		audio-codec = <&sgtl5000>;
 	};
 
-	backlight_display: backlight {
+	backlight_display: backlight@0 {
 		compatible = "pwm-backlight";
 		pwms = <&pwm 0 50000>, <&pwm 1 50000>;
 		brightness-levels = <0 4 8 16 32 64 128 255>;
 		default-brightness-level = <4>;  //Set 4 for identification on probing
 	};
 
+	slcd_backlight: backlight@1 {
+		compatible = "pwm-backlight";
+		pwms = <&pwm 2 50000>;
+		brightness-levels = <0 63 127 255>;
+		default-brightness-level = <3>;
+	};
+
 	buzzer_cold: buzzer_cold {
 		compatible = "regulator-fixed";
 		regulator-name = "fixed-supply";

From d94bc6d2e169d73df64117591eb61027a2a358b0 Mon Sep 17 00:00:00 2001
From: Suguru Saito <sg.sgch07@gmail.com>
Date: Mon, 4 Oct 2021 12:22:07 +0900
Subject: [PATCH 5/5] drm: add st7586 driver for Sharp Brain 2nd generation
 SubLCD

---
 drivers/gpu/drm/tiny/brain-st7586.c | 443 ++++++++++++++++++++++++++++
 1 file changed, 443 insertions(+)
 create mode 100644 drivers/gpu/drm/tiny/brain-st7586.c

diff --git a/drivers/gpu/drm/tiny/brain-st7586.c b/drivers/gpu/drm/tiny/brain-st7586.c
new file mode 100644
index 000000000000..ced526ca3cfb
--- /dev/null
+++ b/drivers/gpu/drm/tiny/brain-st7586.c
@@ -0,0 +1,443 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * DRM driver for Sitronix ST7586 panels for Brain 2nd SubLCD
+ *
+ * Copyright 2021 Suguru Saito <sg.sgch07@gmail.com>
+ *
+ * based on st7586.c
+ * Copyright 2017 David Lechner <david@lechnology.com>
+ */
+
+#include <linux/delay.h>
+#include <linux/dma-buf.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/property.h>
+#include <linux/spi/spi.h>
+#include <video/mipi_display.h>
+
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_damage_helper.h>
+#include <drm/drm_drv.h>
+#include <drm/drm_fb_cma_helper.h>
+#include <drm/drm_fb_helper.h>
+#include <drm/drm_format_helper.h>
+#include <drm/drm_gem_cma_helper.h>
+#include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_mipi_dbi.h>
+#include <drm/drm_rect.h>
+#include <drm/drm_vblank.h>
+
+/* controller-specific commands */
+#define ST7586_DISP_MODE_GRAY	0x38
+#define ST7586_DISP_MODE_MONO	0x39
+#define ST7586_ENABLE_DDRAM	0x3a
+#define ST7586_SET_DISP_DUTY	0xb0
+#define ST7586_SET_OUTPUT_COM	0xb1
+#define ST7586_SET_PART_DISP	0xb4
+#define ST7586_SET_NLINE_INV	0xb5
+#define ST7586_SET_VOP		0xc0
+#define ST7586_SET_BIAS_SYSTEM	0xc3
+#define ST7586_SET_BOOST_LEVEL	0xc4
+#define ST7586_SET_VOP_OFFSET	0xc7
+#define ST7586_ENABLE_ANALOG	0xd0
+#define ST7586_AUTO_READ_CTRL	0xd7
+#define ST7586_OTP_RW_CTRL	0xe0
+#define ST7586_OTP_CTRL_OUT	0xe1
+#define ST7586_OTP_READ		0xe3
+
+#define ST7586_DISP_CTRL_MX	BIT(6)
+#define ST7586_DISP_CTRL_MY	BIT(7)
+
+#define BRAIN_PAGE_OFFSET	0x28
+
+/*
+ * The ST7586 controller has an unusual pixel format where 2bpp grayscale is
+ * packed 3 pixels per byte with the first two pixels using 3 bits and the 3rd
+ * pixel using only 2 bits.
+ *
+ * |  D7  |  D6  |  D5  ||      |      || 2bpp |
+ * | (D4) | (D3) | (D2) ||  D1  |  D0  || GRAY |
+ * +------+------+------++------+------++------+
+ * |  1   |  1   |  1   ||  1   |  1   || 0  0 | black
+ * |  1   |  0   |  0   ||  1   |  0   || 0  1 | dark gray
+ * |  0   |  1   |  0   ||  0   |  1   || 1  0 | light gray
+ * |  0   |  0   |  0   ||  0   |  0   || 1  1 | white
+ */
+
+static const u8 st7586_lookup[] = { 0x7, 0x4, 0x2, 0x0 };
+
+static void st7586_xrgb8888_to_gray332_word(u16 *dst, void *vaddr,
+				       struct drm_framebuffer *fb,
+				       struct drm_rect *clip)
+{
+	size_t len = (clip->x2 - clip->x1) * (clip->y2 - clip->y1);
+	unsigned int x, y;
+	u8 *src, *buf;
+	u16 packed;
+
+	buf = kmalloc(len, GFP_KERNEL);
+	if (!buf)
+		return;
+
+	drm_fb_xrgb8888_to_gray8(buf, vaddr, fb, clip);
+	src = buf;
+
+	for (y = clip->y1; y < clip->y2; y++) {
+		for (x = clip->x1; x < clip->x2; x += 3*2) {
+			/*
+			 * buf: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, a, b, ...
+			 * dst: 210543, 876ba9, ...
+			 */
+			packed = (st7586_lookup[*src++ >> 6] & 0x03) << 8;
+			packed |= st7586_lookup[*src++ >> 6] << 10;
+			packed |= st7586_lookup[*src++ >> 6] << 13;
+			packed |= (st7586_lookup[*src++ >> 6] & 0x03) << 0;
+			packed |= st7586_lookup[*src++ >> 6] << 2;
+			packed |= st7586_lookup[*src++ >> 6] << 5;
+
+			*dst++ = packed;
+		}
+	}
+
+	kfree(buf);
+}
+
+static int st7586_buf_copy(void *dst, struct drm_framebuffer *fb,
+			   struct drm_rect *clip)
+{
+	struct drm_gem_cma_object *cma_obj = drm_fb_cma_get_gem_obj(fb, 0);
+	struct dma_buf_attachment *import_attach = cma_obj->base.import_attach;
+	void *src = cma_obj->vaddr;
+	int ret = 0;
+
+	if (import_attach) {
+		ret = dma_buf_begin_cpu_access(import_attach->dmabuf,
+					       DMA_FROM_DEVICE);
+		if (ret)
+			return ret;
+	}
+
+	st7586_xrgb8888_to_gray332_word(dst, src, fb, clip);
+
+	if (import_attach)
+		ret = dma_buf_end_cpu_access(import_attach->dmabuf,
+					     DMA_FROM_DEVICE);
+
+	return ret;
+}
+
+static void st7586_fb_dirty(struct drm_framebuffer *fb, struct drm_rect *rect)
+{
+	struct mipi_dbi_dev *dbidev = drm_to_mipi_dbi_dev(fb->dev);
+	struct mipi_dbi *dbi = &dbidev->dbi;
+	int start_col, end_col, start_page, end_page, len, idx, ret = 0;
+
+	if (!dbidev->enabled)
+		return;
+
+	if (!drm_dev_enter(fb->dev, &idx))
+		return;
+
+	/* 3 pixels per byte, so grow clip to nearest multiple of 3 */
+	rect->x1 = rounddown(rect->x1, 3);
+	rect->x2 = roundup(rect->x2, 3);
+
+	DRM_DEBUG_KMS("Flushing [FB:%d] " DRM_RECT_FMT "\n", fb->base.id, DRM_RECT_ARG(rect));
+
+	ret = st7586_buf_copy(dbidev->tx_buf, fb, rect);
+	if (ret)
+		goto err_msg;
+
+	/* Pixels are packed 3 per byte */
+	start_col = rect->x1 / 3;
+	end_col = rect->x2 / 3;
+
+	len = (end_col - start_col) * (rect->y2 - rect->y1) / 2;
+
+	/* Write to top-side DDRAM */
+	start_page = rect->y1 + BRAIN_PAGE_OFFSET;
+	end_page = (rect->y2 - rect->y1) / 2 + BRAIN_PAGE_OFFSET;
+	mipi_dbi_command(dbi, MIPI_DCS_SET_COLUMN_ADDRESS,
+			 (start_col >> 8) & 0xFF, start_col & 0xFF,
+			 (end_col >> 8) & 0xFF, (end_col - 1) & 0xFF);
+	mipi_dbi_command(dbi, MIPI_DCS_SET_PAGE_ADDRESS,
+			 (start_page >> 8) & 0xFF, start_page & 0xFF,
+			 (end_page >> 8) & 0xFF, (end_page - 1) & 0xFF);
+
+	ret = mipi_dbi_command_buf(dbi, MIPI_DCS_WRITE_MEMORY_START,
+				   (u8 *)dbidev->tx_buf, len);
+	if (ret)
+		goto err_msg;
+
+	/* Write to bottom-side DDRAM */
+	start_page = (rect->y2 - rect->y1) / 2 + BRAIN_PAGE_OFFSET;
+	end_page = rect->y2 + BRAIN_PAGE_OFFSET;
+	mipi_dbi_command(dbi, MIPI_DCS_SET_COLUMN_ADDRESS,
+			 (start_col >> 8) & 0xFF, start_col & 0xFF,
+			 (end_col >> 8) & 0xFF, (end_col - 1) & 0xFF);
+	mipi_dbi_command(dbi, MIPI_DCS_SET_PAGE_ADDRESS,
+			 (start_page >> 8) & 0xFF, start_page & 0xFF,
+			 (end_page >> 8) & 0xFF, (end_page - 1) & 0xFF);
+
+	ret = mipi_dbi_command_buf(dbi, MIPI_DCS_WRITE_MEMORY_START,
+				   ((u8 *)dbidev->tx_buf) + len, len);
+err_msg:
+	if (ret)
+		dev_err_once(fb->dev->dev, "Failed to update display %d\n", ret);
+
+	drm_dev_exit(idx);
+}
+
+static void st7586_pipe_update(struct drm_simple_display_pipe *pipe,
+			       struct drm_plane_state *old_state)
+{
+	struct drm_plane_state *state = pipe->plane.state;
+	struct drm_crtc *crtc = &pipe->crtc;
+	struct drm_rect rect;
+
+	if (drm_atomic_helper_damage_merged(old_state, state, &rect))
+		st7586_fb_dirty(state->fb, &rect);
+
+	if (crtc->state->event) {
+		spin_lock_irq(&crtc->dev->event_lock);
+		drm_crtc_send_vblank_event(crtc, crtc->state->event);
+		spin_unlock_irq(&crtc->dev->event_lock);
+		crtc->state->event = NULL;
+	}
+}
+
+static void st7586_pipe_enable(struct drm_simple_display_pipe *pipe,
+			       struct drm_crtc_state *crtc_state,
+			       struct drm_plane_state *plane_state)
+{
+	struct mipi_dbi_dev *dbidev = drm_to_mipi_dbi_dev(pipe->crtc.dev);
+	struct drm_framebuffer *fb = plane_state->fb;
+	struct mipi_dbi *dbi = &dbidev->dbi;
+	struct drm_rect rect = {
+		.x1 = 0,
+		.x2 = fb->width,
+		.y1 = 0,
+		.y2 = fb->height,
+	};
+	int idx, ret;
+	u8 addr_mode;
+
+	if (!drm_dev_enter(pipe->crtc.dev, &idx))
+		return;
+
+	DRM_DEBUG_KMS("\n");
+
+	ret = mipi_dbi_poweron_reset(dbidev);
+	if (ret)
+		goto out_exit;
+
+	mipi_dbi_command(dbi, ST7586_AUTO_READ_CTRL, 0x9f);
+	mipi_dbi_command(dbi, ST7586_OTP_RW_CTRL, 0x00);
+
+	msleep(10);
+
+	mipi_dbi_command(dbi, ST7586_OTP_READ);
+
+	msleep(20);
+
+	mipi_dbi_command(dbi, ST7586_OTP_CTRL_OUT);
+	mipi_dbi_command(dbi, MIPI_DCS_EXIT_SLEEP_MODE);
+	mipi_dbi_command(dbi, MIPI_DCS_SET_DISPLAY_OFF);
+
+	msleep(50);
+
+	mipi_dbi_command(dbi, ST7586_SET_VOP_OFFSET, 0x00);
+	mipi_dbi_command(dbi, ST7586_SET_VOP, 0x19, 0x01);
+	mipi_dbi_command(dbi, ST7586_SET_BIAS_SYSTEM, 0x03);
+	mipi_dbi_command(dbi, ST7586_SET_BOOST_LEVEL, 0x07);
+	mipi_dbi_command(dbi, ST7586_ENABLE_ANALOG, 0x1d);
+	mipi_dbi_command(dbi, ST7586_SET_NLINE_INV, 0x00);
+	mipi_dbi_command(dbi, ST7586_DISP_MODE_GRAY);
+	mipi_dbi_command(dbi, ST7586_ENABLE_DDRAM, 0x02);
+
+	switch (dbidev->rotation) {
+	default:
+		addr_mode = 0x00;
+		break;
+	case 90:
+		addr_mode = ST7586_DISP_CTRL_MY;
+		break;
+	case 180:
+		addr_mode = ST7586_DISP_CTRL_MX | ST7586_DISP_CTRL_MY;
+		break;
+	case 270:
+		addr_mode = ST7586_DISP_CTRL_MX;
+		break;
+	}
+	mipi_dbi_command(dbi, MIPI_DCS_SET_ADDRESS_MODE, addr_mode);
+
+	mipi_dbi_command(dbi, ST7586_SET_DISP_DUTY, 0x77);
+	mipi_dbi_command(dbi, ST7586_SET_OUTPUT_COM, BRAIN_PAGE_OFFSET);
+	mipi_dbi_command(dbi, ST7586_SET_PART_DISP, 0xa0);
+	mipi_dbi_command(dbi, MIPI_DCS_SET_PARTIAL_AREA, 0x00, 0x00, 0x00, 0x9f);
+	mipi_dbi_command(dbi, MIPI_DCS_EXIT_INVERT_MODE);
+
+	msleep(100);
+
+	dbidev->enabled = true;
+	st7586_fb_dirty(fb, &rect);
+
+	mipi_dbi_command(dbi, MIPI_DCS_SET_DISPLAY_ON);
+out_exit:
+	drm_dev_exit(idx);
+}
+
+static void st7586_pipe_disable(struct drm_simple_display_pipe *pipe)
+{
+	struct mipi_dbi_dev *dbidev = drm_to_mipi_dbi_dev(pipe->crtc.dev);
+
+	/*
+	 * This callback is not protected by drm_dev_enter/exit since we want to
+	 * turn off the display on regular driver unload. It's highly unlikely
+	 * that the underlying SPI controller is gone should this be called after
+	 * unplug.
+	 */
+
+	DRM_DEBUG_KMS("\n");
+
+	if (!dbidev->enabled)
+		return;
+
+	mipi_dbi_command(&dbidev->dbi, MIPI_DCS_SET_DISPLAY_OFF);
+	dbidev->enabled = false;
+}
+
+static const u32 st7586_formats[] = {
+	DRM_FORMAT_XRGB8888,
+};
+
+static const struct drm_simple_display_pipe_funcs st7586_pipe_funcs = {
+	.enable		= st7586_pipe_enable,
+	.disable	= st7586_pipe_disable,
+	.update		= st7586_pipe_update,
+	.prepare_fb	= drm_gem_fb_simple_display_pipe_prepare_fb,
+};
+
+static const struct drm_display_mode st7586_mode = {
+	DRM_SIMPLE_MODE(240, 120, 51, 26),
+};
+
+DEFINE_DRM_GEM_CMA_FOPS(st7586_fops);
+
+static struct drm_driver st7586_driver = {
+	.driver_features	= DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC,
+	.fops			= &st7586_fops,
+	.release		= mipi_dbi_release,
+	DRM_GEM_CMA_VMAP_DRIVER_OPS,
+	.debugfs_init		= mipi_dbi_debugfs_init,
+	.name			= "brain-st7586",
+	.desc			= "Sitronix ST7586 for Sharp Brain 2nd generation SubLCD",
+	.date			= "20211002",
+	.major			= 1,
+	.minor			= 0,
+};
+
+static const struct of_device_id st7586_of_match[] = {
+	{ .compatible = "brain,st7586" },
+	{},
+};
+MODULE_DEVICE_TABLE(of, st7586_of_match);
+
+static const struct spi_device_id st7586_id[] = {
+	{ "brain-slcd", 0 },
+	{ },
+};
+MODULE_DEVICE_TABLE(spi, st7586_id);
+
+static int st7586_probe(struct spi_device *spi)
+{
+	struct device *dev = &spi->dev;
+	struct mipi_dbi_dev *dbidev;
+	struct drm_device *drm;
+	struct mipi_dbi *dbi;
+	u32 rotation = 0;
+	size_t bufsize;
+	int ret;
+
+	dbidev = kzalloc(sizeof(*dbidev), GFP_KERNEL);
+	if (!dbidev)
+		return -ENOMEM;
+
+	dbi = &dbidev->dbi;
+	drm = &dbidev->drm;
+	ret = devm_drm_dev_init(dev, drm, &st7586_driver);
+	if (ret) {
+		kfree(dbidev);
+		return ret;
+	}
+
+	drm_mode_config_init(drm);
+
+	bufsize = (st7586_mode.vdisplay + 2) / 3 * st7586_mode.hdisplay;
+
+	dbi->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+	if (IS_ERR(dbi->reset)) {
+		DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n");
+		return PTR_ERR(dbi->reset);
+	}
+
+	device_property_read_u32(dev, "rotation", &rotation);
+
+	ret = mipi_dbi_spi_init(spi, dbi, NULL);
+	if (ret)
+		return ret;
+
+	/* Cannot read from this controller via SPI */
+	dbi->read_commands = NULL;
+
+	ret = mipi_dbi_dev_init_with_formats(dbidev, &st7586_pipe_funcs,
+					     st7586_formats, ARRAY_SIZE(st7586_formats),
+					     &st7586_mode, rotation, bufsize);
+	if (ret)
+		return ret;
+
+	drm_mode_config_reset(drm);
+
+	ret = drm_dev_register(drm, 0);
+	if (ret)
+		return ret;
+
+	spi_set_drvdata(spi, drm);
+
+	drm_fbdev_generic_setup(drm, 0);
+
+	return 0;
+}
+
+static int st7586_remove(struct spi_device *spi)
+{
+	struct drm_device *drm = spi_get_drvdata(spi);
+
+	drm_dev_unplug(drm);
+	drm_atomic_helper_shutdown(drm);
+
+	return 0;
+}
+
+static void st7586_shutdown(struct spi_device *spi)
+{
+	drm_atomic_helper_shutdown(spi_get_drvdata(spi));
+}
+
+static struct spi_driver st7586_spi_driver = {
+	.driver = {
+		.name = "brain-st7586",
+		.owner = THIS_MODULE,
+		.of_match_table = st7586_of_match,
+	},
+	.id_table = st7586_id,
+	.probe = st7586_probe,
+	.remove = st7586_remove,
+	.shutdown = st7586_shutdown,
+};
+module_spi_driver(st7586_spi_driver);
+
+MODULE_DESCRIPTION("Sitronix ST7586 DRM driver for Sharp Brain 2nd generation SubLCD");
+MODULE_AUTHOR("Suguru Saito <sg.sgch07@gmail.com>");
+MODULE_LICENSE("GPL");