mirror of
https://github.com/brain-hackers/linux-brain.git
synced 2024-06-09 23:36:23 +09:00
Revert "ALSA: usx2y: Fix potential NULL pointer dereference"
[ Upstream commit 4667a6fc1777ce071504bab570d3599107f4790f ]
This reverts commit a2c6433ee5
.
Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.
Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted. It will be fixed up "correctly" in a
later kernel change.
The original patch was incorrect, and would leak memory if the error
path the patch added was hit.
Cc: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20210503115736.2104747-37-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
ea4c563657
commit
5dc2045770
|
@ -91,12 +91,7 @@ static int init_urbs(struct usb_stream_kernel *sk, unsigned use_packsize,
|
|||
|
||||
for (u = 0; u < USB_STREAM_NURBS; ++u) {
|
||||
sk->inurb[u] = usb_alloc_urb(sk->n_o_ps, GFP_KERNEL);
|
||||
if (!sk->inurb[u])
|
||||
return -ENOMEM;
|
||||
|
||||
sk->outurb[u] = usb_alloc_urb(sk->n_o_ps, GFP_KERNEL);
|
||||
if (!sk->outurb[u])
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
if (init_pipe_urbs(sk, use_packsize, sk->inurb, indata, dev, in_pipe) ||
|
||||
|
|
Loading…
Reference in New Issue
Block a user