brain-hackers_pepepper-mirror
/
linux-brain
mirror of https://github.com/brain-hackers/linux-brain.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

atm: he: use 64-bit arithmetic instead of 32-bit 

Add suffix ULL to constants 272, 204, 136 and 68 in order to give the
compiler complete information about the proper arithmetic to use.
Notice that these constants are used in contexts that expect
expressions of type unsigned long long (64 bits, unsigned).

The following expressions are currently being evaluated using 32-bit
arithmetic:

272 * mult
204 * mult
136 * mult
68 * mult

Addresses-Coverity-ID: 201058
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva 2018-02-07 10:17:29 -06:00 committed by David S. Miller
parent 4ff66cae7f
commit 583133b35e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/atm/he.c
View File

@ -738,13 +738,13 @@ static int he_init_cs_block_rcm(struct he_dev *he_dev)
#else
/* this is pretty, but avoids _divdu3 and is mostly correct */
mult = he_dev->atm_dev->link_rate / ATM_OC3_PCR;
if (rate_cps > (272 * mult))
if (rate_cps > (272ULL * mult))
buf = 4;
else if (rate_cps > (204 * mult))
else if (rate_cps > (204ULL * mult))
buf = 3;
else if (rate_cps > (136 * mult))
else if (rate_cps > (136ULL * mult))
buf = 2;
else if (rate_cps > (68 * mult))
else if (rate_cps > (68ULL * mult))
buf = 1;
else
buf = 0;