gpio: sysfs: Obey valid_mask
[ Upstream commit 23cf00ddd2e1aacf1873e43f5e0c519c120daf7a ]
Do not allow exporting GPIOs which are set invalid
by the driver's valid mask.
Fixes: 726cb3ba49
("gpiolib: Support 'gpio-reserved-ranges' property")
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
2dce5702ef
commit
5130cda3cb
|
@ -457,6 +457,8 @@ static ssize_t export_store(struct class *class,
|
||||||
long gpio;
|
long gpio;
|
||||||
struct gpio_desc *desc;
|
struct gpio_desc *desc;
|
||||||
int status;
|
int status;
|
||||||
|
struct gpio_chip *gc;
|
||||||
|
int offset;
|
||||||
|
|
||||||
status = kstrtol(buf, 0, &gpio);
|
status = kstrtol(buf, 0, &gpio);
|
||||||
if (status < 0)
|
if (status < 0)
|
||||||
|
@ -468,6 +470,12 @@ static ssize_t export_store(struct class *class,
|
||||||
pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
|
pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
}
|
}
|
||||||
|
gc = desc->gdev->chip;
|
||||||
|
offset = gpio_chip_hwgpio(desc);
|
||||||
|
if (!gpiochip_line_is_valid(gc, offset)) {
|
||||||
|
pr_warn("%s: GPIO %ld masked\n", __func__, gpio);
|
||||||
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
/* No extra locking here; FLAG_SYSFS just signifies that the
|
/* No extra locking here; FLAG_SYSFS just signifies that the
|
||||||
* request and export were done by on behalf of userspace, so
|
* request and export were done by on behalf of userspace, so
|
||||||
|
|
Loading…
Reference in New Issue