brain-hackers_pepepper-mirror/linux-brain
1
0
Fork 0
mirror of https://github.com/brain-hackers/linux-brain.git synced 2024-06-09 23:36:23 +09:00
Code Issues Projects Releases Wiki Activity

xfs: fix uninitialized error variable

Browse Source 
A previous commit removed the initialization of variable 'error' to zero,
and can cause a bogus error return.  This occurs when error contains a
non-zero garbage value and the call to xchk_should_terminate detects a
pending fatal signal and checks for a zero error before setting it
to -EAGAIN. Fix the issue by initializing error to zero.

Fixes: b9454fe056 ("xfs: clean up the inode cluster checking in the inobt scrub")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
This commit is contained in:
Colin Ian King 2019-02-21 07:53:20 -08:00 committed by Darrick J. Wong
parent 66ae56a53f
commit 081a8ae2a5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/scrub/ialloc.c
View File

@ -161,7 +161,7 @@ xchk_iallocbt_check_cluster_ifree(
bool irec_free;
bool ino_inuse;
bool freemask_ok;
int error;
int error = 0;
if (xchk_should_terminate(bs->sc, &error))
return error;