pepepper/tissue
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

200でなかったときのテストを削除

Browse Source 
4xxや5xxの場合は`\GuzzleHttp\Exception\BadResponseException`が発生するので、今まであったelseのところには到達しなかった
This commit is contained in:
eai04191 2019-09-09 13:52:32 +09:00
parent 0f530099b4
commit c0b76e522b
2 changed files with 11 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/MetadataResolver/XtubeResolver.php
View File

@ -24,7 +24,6 @@ class XtubeResolver implements Resolver
} }
$res = $this->client->get($url); $res = $this->client->get($url);
if ($res->getStatusCode() === 200) {
$html = (string) $res->getBody(); $html = (string) $res->getBody();
$metadata = new Metadata(); $metadata = new Metadata();
$crawler = new Crawler($html); $crawler = new Crawler($html);
@ -39,8 +38,5 @@ class XtubeResolver implements Resolver
$metadata->tags = $crawler->filter('.tagsCategories a')->extract('_text'); $metadata->tags = $crawler->filter('.tagsCategories a')->extract('_text');
return $metadata; return $metadata;
} else {
throw new \RuntimeException("{$res->getStatusCode()}: $url");
}
} }
} }

9
tests/Unit/MetadataResolver/XtubeResolverTest.php
View File

@ -42,13 +42,4 @@ class XtubeResolverTest extends TestCase
$this->createResolver(XtubeResolver::class, ''); $this->createResolver(XtubeResolver::class, '');
$this->resolver->resolve('https://www.xtube.com/gallery/black-celebs-free-7686657'); $this->resolver->resolve('https://www.xtube.com/gallery/black-celebs-free-7686657');
} }
public function testNotOK()
{
$this->expectException(\RuntimeException::class);
$this->expectExceptionMessage('404: https://www.xtube.com/video-watch/notfound-404');
$this->createResolver(XtubeResolver::class, '', [], 404);
$this->resolver->resolve('https://www.xtube.com/video-watch/notfound-404');
}
} }