fix(app): correct shortcuts, nagbar, stream menu, share audio (#2599)

fluxer_gateway/src/guild/guild_data_channels.erl

@@ -153,7 +153,9 @@ select_first_viewable(Channel, GuildId, BasePerms) ->
 
 -spec check_viewable(integer() | undefined, integer() | undefined, map(), integer(), integer()) ->
     integer() | null.
-check_viewable(0, ChannelId, Channel, GuildId, BasePerms) when is_integer(ChannelId) ->
+check_viewable(ChannelType, ChannelId, Channel, GuildId, BasePerms) when
+    is_integer(ChannelId), ChannelType =:= 0 orelse ChannelType =:= 2
+->
     case permission_bits:has(BasePerms, constants:administrator_permission()) of
         true -> ChannelId;
         false -> check_view_permission(ChannelId, Channel, GuildId, BasePerms)

fluxer_gateway/test/guild_data_tests.erl

@@ -263,6 +263,46 @@ find_everyone_viewable_text_channel_ignores_user_overwrite_for_guild_id_test() -
     ChannelId = guild_data:find_everyone_viewable_text_channel(Channels, State),
     ?assertEqual(12, ChannelId).
 
+find_everyone_viewable_text_channel_accepts_voice_when_no_text_channel_test() ->
+    GuildId = 100,
+    ViewPerm = constants:view_channel_permission(),
+    State = #{
+        id => GuildId,
+        data => #{
+            <<"roles">> => [
+                #{
+                    <<"id">> => integer_to_binary(GuildId),
+                    <<"permissions">> => integer_to_binary(ViewPerm)
+                }
+            ]
+        }
+    },
+    Channels = [
+        #{<<"id">> => <<"501">>, <<"type">> => 2, <<"permission_overwrites">> => []}
+    ],
+    ChannelId = guild_data:find_everyone_viewable_text_channel(Channels, State),
+    ?assertEqual(501, ChannelId).
+
+find_everyone_viewable_text_channel_skips_link_channel_test() ->
+    GuildId = 100,
+    ViewPerm = constants:view_channel_permission(),
+    State = #{
+        id => GuildId,
+        data => #{
+            <<"roles">> => [
+                #{
+                    <<"id">> => integer_to_binary(GuildId),
+                    <<"permissions">> => integer_to_binary(ViewPerm)
+                }
+            ]
+        }
+    },
+    Channels = [
+        #{<<"id">> => <<"998">>, <<"type">> => 998, <<"permission_overwrites">> => []}
+    ],
+    ChannelId = guild_data:find_everyone_viewable_text_channel(Channels, State),
+    ?assertEqual(null, ChannelId).
+
 voice_members_from_states_reads_embedded_member_test() ->
     EmbeddedMember = #{<<"user">> => #{<<"id">> => <<"300">>}, <<"roles">> => []},
     IndexedMember = #{<<"user">> => #{<<"id">> => <<"200">>}, <<"roles">> => []},