test(message): count permission fetches instead of view checks (#2193)

This commit is contained in:
Hampus authored and GitHub committed 2026-08-30 23:25:47 +02:00
1 parent 933b13f3fa
commit e7f68c2e20
1 file changed
+7 -9
@@ -106,9 +106,7 @@ describe('Message send permissions', () => {
const gatewayService = getGatewayService(); const gatewayService = getGatewayService();
const getGuildData = vi.spyOn(gatewayService, 'getGuildData'); const getGuildData = vi.spyOn(gatewayService, 'getGuildData');
const getGuildMember = vi.spyOn(gatewayService, 'getGuildMember'); const getGuildMember = vi.spyOn(gatewayService, 'getGuildMember');
const checkPermission = vi.spyOn(gatewayService, 'checkPermission'); const getUserPermissions = vi.spyOn(gatewayService, 'getUserPermissions');
const countViewChannelChecks = () =>
checkPermission.mock.calls.filter((call) => call[0].permission === Permissions.VIEW_CHANNEL).length;
try { try {
const sentMessage = await createBuilder<MessageResponse>(harness, member.token) const sentMessage = await createBuilder<MessageResponse>(harness, member.token)
@@ -118,11 +116,11 @@ describe('Message send permissions', () => {
const sendCounts = { const sendCounts = {
guildData: getGuildData.mock.calls.length, guildData: getGuildData.mock.calls.length,
guildMember: getGuildMember.mock.calls.length, guildMember: getGuildMember.mock.calls.length,
viewChannel: countViewChannelChecks(), userPermissions: getUserPermissions.mock.calls.length,
}; };
getGuildData.mockClear(); getGuildData.mockClear();
getGuildMember.mockClear(); getGuildMember.mockClear();
checkPermission.mockClear(); getUserPermissions.mockClear();
await createBuilder<MessageResponse>(harness, member.token) await createBuilder<MessageResponse>(harness, member.token)
.patch(`/channels/${systemChannel.id}/messages/${sentMessage.id}`) .patch(`/channels/${systemChannel.id}/messages/${sentMessage.id}`)
.body({content: 'authenticate me once again'}) .body({content: 'authenticate me once again'})
@@ -130,15 +128,15 @@ describe('Message send permissions', () => {
const editCounts = { const editCounts = {
guildData: getGuildData.mock.calls.length, guildData: getGuildData.mock.calls.length,
guildMember: getGuildMember.mock.calls.length, guildMember: getGuildMember.mock.calls.length,
viewChannel: countViewChannelChecks(), userPermissions: getUserPermissions.mock.calls.length,
}; };
expect(sendCounts).toEqual({guildData: 1, guildMember: 1, viewChannel: 1}); expect(sendCounts).toEqual({guildData: 1, guildMember: 1, userPermissions: 1});
expect(editCounts).toEqual({guildData: 1, guildMember: 1, viewChannel: 1}); expect(editCounts).toEqual({guildData: 1, guildMember: 1, userPermissions: 1});
} finally { } finally {
getGuildData.mockRestore(); getGuildData.mockRestore();
getGuildMember.mockRestore(); getGuildMember.mockRestore();
checkPermission.mockRestore(); getUserPermissions.mockRestore();
} }
}); });