feat(api): redirect desktop downloads to pkgs (#2853)

fluxer_api/src/api/infrastructure/StorageService.ts

@@ -35,7 +35,7 @@ import {
 } from '@aws-sdk/client-s3';
 import {Upload} from '@aws-sdk/lib-storage';
 import {getSignedUrl} from '@aws-sdk/s3-request-presigner';
-import type {S3ProviderSettings} from '@fluxer/config/src/S3DownloadsProvider';
+import type {S3ProviderSettings} from '@fluxer/config/src/S3ProviderSettings';
 import {isSupportedMediaContentType} from '@pkgs/mime_utils/src/ContentTypeUtils';
 import {seconds} from 'itty-time';
 import {temporaryFile} from 'tempy';

fluxer_api/src/api/infrastructure/StorageServiceFactory.test.ts

@@ -1,18 +0,0 @@
-// SPDX-License-Identifier: AGPL-3.0-or-later
-
-import {Config} from '@app/api/Config';
-import {createDownloadsStorageService} from '@app/api/infrastructure/StorageServiceFactory';
-import {describe, expect, it} from 'vitest';
-
-describe('createDownloadsStorageService', () => {
-	it('returns null when no downloads override is configured', () => {
-		expect(Config.s3Downloads.isOverridden).toBe(false);
-		expect(createDownloadsStorageService()).toBeNull();
-	});
-
-	it('resolves the downloads provider to the shared provider by default', () => {
-		expect(Config.s3Downloads.settings.endpoint).toBe(Config.s3.endpoint);
-		expect(Config.s3Downloads.settings.region).toBe(Config.s3.region);
-		expect(Config.s3Downloads.settings.accessKeyId).toBe(Config.s3.accessKeyId);
-	});
-});

fluxer_api/src/api/infrastructure/StorageServiceFactory.ts

@@ -25,13 +25,6 @@ export function createStorageService(): IStorageService {
 	return withChangeFeed(new StorageService());
 }
 
-export function createDownloadsStorageService(): IStorageService | null {
-	if (!Config.s3Downloads.isOverridden) {
-		return null;
-	}
-	return withChangeFeed(new StorageService(Config.s3Downloads.settings));
-}
-
 export async function shutdownStorageChangeFeed(): Promise<void> {
 	const feed = changeFeed;
 	changeFeed = null;