From d1aa49f4f95f869b24f58841344d3766fb5f6c70 Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Thu, 9 Jul 2026 21:57:25 +0100 Subject: [PATCH] fix(GitHubPullRequestTransformer): use `sender` (#1351) --- .../api/webhook/tests/GitHubPullRequestTransformer.test.ts | 6 ++++-- .../webhook/transformers/GitHubPullRequestTransformer.ts | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/fluxer_api/src/api/webhook/tests/GitHubPullRequestTransformer.test.ts b/fluxer_api/src/api/webhook/tests/GitHubPullRequestTransformer.test.ts index 5e28c46bc..5d4b7580e 100644 --- a/fluxer_api/src/api/webhook/tests/GitHubPullRequestTransformer.test.ts +++ b/fluxer_api/src/api/webhook/tests/GitHubPullRequestTransformer.test.ts @@ -60,8 +60,8 @@ describe('GitHub Pull Request Transformer', () => { expect(result?.url).toBe('https://github.com/org/repo/pull/42'); expect(result?.color).toBe(0x098efc); expect(result?.description).toContain('amazing feature'); - expect(result?.author?.name).toBe('prauthor'); - expect(result?.author?.url).toBe('https://github.com/prauthor'); + expect(result?.author?.name).toBe('testuser'); + expect(result?.author?.url).toBe('https://github.com/testuser'); }); it('transforms a closed pull request', async () => { const payload: GitHubWebhook = { @@ -75,6 +75,7 @@ describe('GitHub Pull Request Transformer', () => { expect(result?.title).toContain('Pull request closed'); expect(result?.color).toBe(0x000000); expect(result?.description).toBeUndefined(); + expect(result?.author?.name).toBe('testuser'); }); it('transforms a reopened pull request', async () => { const payload: GitHubWebhook = { @@ -87,6 +88,7 @@ describe('GitHub Pull Request Transformer', () => { expect(result).not.toBeNull(); expect(result?.title).toContain('Pull request reopened'); expect(result?.color).toBe(0xfcbd1f); + expect(result?.author?.name).toBe('testuser'); }); it('returns null for unsupported action types', async () => { const payload: GitHubWebhook = { diff --git a/fluxer_api/src/api/webhook/transformers/GitHubPullRequestTransformer.ts b/fluxer_api/src/api/webhook/transformers/GitHubPullRequestTransformer.ts index 0bafe4a3e..fbc7601a7 100644 --- a/fluxer_api/src/api/webhook/transformers/GitHubPullRequestTransformer.ts +++ b/fluxer_api/src/api/webhook/transformers/GitHubPullRequestTransformer.ts @@ -14,9 +14,9 @@ export async function transformPullRequest(body: GitHubWebhook): Promise