feat(app): gate a collapsing guild header behind an experiment (#2779)

fluxer_api/src/api/instance/InstanceConfigRepository.test.ts

@@ -29,6 +29,10 @@ import {
 	DEFAULT_GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG,
 	type GuildActivityLogPresentationConfig,
 } from '@fluxer/schema/src/domains/experiment/GuildActivityLogPresentationSchemas';
+import {
+	DEFAULT_GUILD_HEADER_COLLAPSE_CONFIG,
+	type GuildHeaderCollapseConfig,
+} from '@fluxer/schema/src/domains/experiment/GuildHeaderCollapseSchemas';
 import {
 	DEFAULT_MESSAGE_HOVER_TRACKING_CONFIG,
 	type MessageHoverTrackingConfig,
@@ -45,6 +49,7 @@ const MESSAGE_KEYBOARD_FOCUS_CONFIG_KEY = 'message_keyboard_focus_config';
 const BLOCKED_MESSAGE_GROUPS_CONFIG_KEY = 'blocked_message_groups_config';
 const GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG_KEY = 'guild_activity_log_presentation_config';
 const EXPRESSION_INFO_CARD_CONFIG_KEY = 'expression_info_card_config';
+const GUILD_HEADER_COLLAPSE_CONFIG_KEY = 'guild_header_collapse_config';
 const EXPERIMENT_DELIVERY_CONFIG_KEY = 'experiment_delivery_config';
 const APP_PUBLIC_CONFIG_KEY = 'app_public_config';
 const INSTANCE_POLICY_CONFIG_KEY = 'instance_policy_config';
@@ -566,6 +571,70 @@ describe('InstanceConfigRepository', () => {
 		await expect(repository.getExpressionInfoCardConfig()).resolves.toEqual(config);
 	});
 
+	it('returns the default guild header collapse config when the key is absent', async () => {
+		const executor = new CountingInMemoryCassandraQueryExecutor();
+		setCassandraQueryExecutorForTesting(executor);
+		const kvProvider = new MockKVProvider();
+		const repository = createRepository(kvProvider);
+
+		await expect(repository.getGuildHeaderCollapseConfig()).resolves.toEqual(DEFAULT_GUILD_HEADER_COLLAPSE_CONFIG);
+	});
+
+	it.each([
+		{name: 'unparseable text', stored: 'not-json'},
+		{name: 'a json array', stored: '[]'},
+		{name: 'out-of-range values', stored: '{"rollout_basis_points":99999}'},
+		{name: 'a target that is not a snowflake', stored: '{"included_user_ids":["nope"]}'},
+	])('falls back to the default guild header collapse config for $name', async ({stored}) => {
+		const executor = new CountingInMemoryCassandraQueryExecutor();
+		setCassandraQueryExecutorForTesting(executor);
+		const kvProvider = new MockKVProvider();
+		const repository = createRepository(kvProvider);
+
+		await repository.setConfig(GUILD_HEADER_COLLAPSE_CONFIG_KEY, stored);
+
+		await expect(repository.getGuildHeaderCollapseConfig()).resolves.toEqual(DEFAULT_GUILD_HEADER_COLLAPSE_CONFIG);
+	});
+
+	it('round-trips a stored guild header collapse config', async () => {
+		const executor = new CountingInMemoryCassandraQueryExecutor();
+		setCassandraQueryExecutorForTesting(executor);
+		const kvProvider = new MockKVProvider();
+		const repository = createRepository(kvProvider);
+
+		const config: GuildHeaderCollapseConfig = {
+			...DEFAULT_GUILD_HEADER_COLLAPSE_CONFIG,
+			enabled: true,
+			config_version: 5,
+			rollout_basis_points: 1500,
+			rollout_salt: 'guild-header-collapse-v2',
+			included_user_ids: ['1400000000000000001'],
+			excluded_user_ids: ['1400000000000000002'],
+		};
+		await repository.setGuildHeaderCollapseConfig(config);
+
+		await expect(repository.getGuildHeaderCollapseConfig()).resolves.toEqual(config);
+	});
+
+	it('fills newly added guild header collapse fields from the schema defaults', async () => {
+		const executor = new CountingInMemoryCassandraQueryExecutor();
+		setCassandraQueryExecutorForTesting(executor);
+		const kvProvider = new MockKVProvider();
+		const repository = createRepository(kvProvider);
+
+		await repository.setConfig(
+			GUILD_HEADER_COLLAPSE_CONFIG_KEY,
+			JSON.stringify({enabled: true, config_version: 2, rollout_basis_points: 1000}),
+		);
+
+		await expect(repository.getGuildHeaderCollapseConfig()).resolves.toEqual({
+			...DEFAULT_GUILD_HEADER_COLLAPSE_CONFIG,
+			enabled: true,
+			config_version: 2,
+			rollout_basis_points: 1000,
+		});
+	});
+
 	it('fills newly added voice noise suppression fields from the schema defaults', async () => {
 		const executor = new CountingInMemoryCassandraQueryExecutor();
 		setCassandraQueryExecutorForTesting(executor);

fluxer_api/src/api/instance/InstanceConfigRepository.ts

@@ -48,6 +48,10 @@ import {
 	type GuildActivityLogPresentationConfig,
 	GuildActivityLogPresentationConfigSchema,
 } from '@fluxer/schema/src/domains/experiment/GuildActivityLogPresentationSchemas';
+import {
+	type GuildHeaderCollapseConfig,
+	GuildHeaderCollapseConfigSchema,
+} from '@fluxer/schema/src/domains/experiment/GuildHeaderCollapseSchemas';
 import {
 	type MessageHoverTrackingConfig,
 	MessageHoverTrackingConfigSchema,
@@ -80,6 +84,7 @@ const MESSAGE_HOVER_TRACKING_CONFIG_KEY = 'message_hover_tracking_config';
 const MESSAGE_KEYBOARD_FOCUS_CONFIG_KEY = 'message_keyboard_focus_config';
 const BLOCKED_MESSAGE_GROUPS_CONFIG_KEY = 'blocked_message_groups_config';
 const EXPRESSION_INFO_CARD_CONFIG_KEY = 'expression_info_card_config';
+const GUILD_HEADER_COLLAPSE_CONFIG_KEY = 'guild_header_collapse_config';
 const REGISTRATION_CONFIG_KEY = 'registration_config';
 const REGISTRATION_URLS_KEY = 'registration_urls';
 const REGISTRATION_PENDING_APPROVALS_KEY = 'registration_pending_approvals';
@@ -368,6 +373,7 @@ type StoredConfigSection =
 	| 'message keyboard focus'
 	| 'blocked message groups'
 	| 'expression info card'
+	| 'guild header collapse'
 	| 'instance policy'
 	| 'integrations'
 	| 'media'
@@ -529,6 +535,10 @@ function parseStoredExpressionInfoCardConfig(raw: string | null): ExpressionInfo
 	return parseStoredConfigOrDefault(ExpressionInfoCardConfigSchema, raw, 'expression info card');
 }
 
+function parseStoredGuildHeaderCollapseConfig(raw: string | null): GuildHeaderCollapseConfig {
+	return parseStoredConfigOrDefault(GuildHeaderCollapseConfigSchema, raw, 'guild header collapse');
+}
+
 function validateStoredCollection<T>(schema: z.ZodType<T>, value: unknown, section: StoredConfigSection): Array<T> {
 	if (!Array.isArray(value)) {
 		throw new Error(`Stored ${section} configuration must be an array`);
@@ -1053,6 +1063,7 @@ export class InstanceConfigRepository {
 		parseStoredMessageKeyboardFocusConfig(snapshot.get(MESSAGE_KEYBOARD_FOCUS_CONFIG_KEY) ?? null);
 		parseStoredBlockedMessageGroupsConfig(snapshot.get(BLOCKED_MESSAGE_GROUPS_CONFIG_KEY) ?? null);
 		parseStoredExpressionInfoCardConfig(snapshot.get(EXPRESSION_INFO_CARD_CONFIG_KEY) ?? null);
+		parseStoredGuildHeaderCollapseConfig(snapshot.get(GUILD_HEADER_COLLAPSE_CONFIG_KEY) ?? null);
 		const policy = parseStoredInstancePolicyConfig(snapshot.get(INSTANCE_POLICY_CONFIG_KEY) ?? null);
 		checkStoredConfig('registration', () =>
 			parseStoredRegistrationConfig(snapshot.get(REGISTRATION_CONFIG_KEY) ?? null),
@@ -1192,6 +1203,16 @@ export class InstanceConfigRepository {
 		await this.setConfig(EXPRESSION_INFO_CARD_CONFIG_KEY, JSON.stringify(validated));
 	}
 
+	async getGuildHeaderCollapseConfig(): Promise<GuildHeaderCollapseConfig> {
+		const raw = await this.getConfig(GUILD_HEADER_COLLAPSE_CONFIG_KEY);
+		return parseStoredGuildHeaderCollapseConfig(raw);
+	}
+
+	async setGuildHeaderCollapseConfig(config: GuildHeaderCollapseConfig): Promise<void> {
+		const validated = validateStoredConfig(GuildHeaderCollapseConfigSchema, config, 'guild header collapse');
+		await this.setConfig(GUILD_HEADER_COLLAPSE_CONFIG_KEY, JSON.stringify(validated));
+	}
+
 	async setExperimentDeliveryConfig(config: ExperimentDeliveryConfig): Promise<void> {
 		const validated = validateStoredConfig(ExperimentDeliveryConfigSchema, config, 'experiment delivery');
 		await this.setConfig(EXPERIMENT_DELIVERY_CONFIG_KEY, JSON.stringify(validated));