pepepper/fluxer
1
0 Fork 0
mirror of https://github.com/fluxerapp/fluxer synced 2026-10-17 21:15:32 +09:00
Code Issues Packages Projects Releases Wiki Activity

refactor(voice): remove screen share codec renegotiation (#2417)

Browse Source
This commit is contained in:
Hampus authored and GitHub committed 2026-09-03 04:46:11 +02:00
1 parent f5f60c66e7
commit c97bc53342
80 files changed
+1360 -4726
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

fluxer_app/src/features/user/components/modals/tabs/AdvancedSettingDirectControls.tsx
-6
View File
@@ -40,7 +40,6 @@ import {
} from '@app/features/user/components/modals/tabs/advanced_settings_tab/AdvancedDesktopControls';
import {UnreadBadgeCustomizationControl} from '@app/features/user/components/modals/tabs/advanced_settings_tab/AdvancedExperimentalControls';
import {
EmulatedDecodeCodecCapControl,
OpenH264Control,
ScreenShareAv1OptInControl,
ScreenShareCodecControl,
@@ -87,7 +86,6 @@ export const DIRECT_CONTROL_ITEM_IDS = new Set([
'voice-video-screen-share-codec',
'voice-video-screen-share-av1-opt-in',
'voice-video-screen-share-hevc-opt-in',
'voice-video-emulated-decode-codec-cap',
'voice-video-openh264-codec',
'voice-video-screen-share-preview-behavior',
'voice-video-screen-share-encoder-controls',
@@ -281,10 +279,6 @@ export const AdvancedSettingControl = observer(({item}: {item: SearchableSetting
return (
<ScreenShareHevcOptInControl data-flx="user.advanced-setting-direct-controls.advanced-setting-control.screen-share-hevc-opt-in-control" />
);
case 'voice-video-emulated-decode-codec-cap':
return (
<EmulatedDecodeCodecCapControl data-flx="user.advanced-setting-direct-controls.advanced-setting-control.emulated-decode-codec-cap-control" />
);
case 'voice-video-openh264-codec':
return (
<OpenH264Control data-flx="user.advanced-setting-direct-controls.advanced-setting-control.open-h264-control" />
fluxer_app/src/features/user/components/modals/tabs/advanced_settings_tab/AdvancedVideoControls.tsx
-31
View File
@@ -161,14 +161,6 @@ const CONFIGURE_DESCRIPTOR = msg({
message: 'Configure',
comment: 'Button label that opens a dedicated advanced settings modal for configuring screen-share encoder controls.',
});
const DECODE_CODEC_CAP_DESCRIPTOR = msg({
message: 'Emulate decode codec (testing)',
comment: 'Label for an advanced select that caps the best video codec this client advertises it can decode.',
});
const DECODE_CODEC_CAP_AUTO_DESCRIPTOR = msg({
message: 'Automatic',
comment: 'Option label for the emulated decode codec select. Means advertise true decode support.',
});
const PREFERRED_SCREEN_SHARE_CODEC_DESCRIPTOR = msg({
message: 'Preferred screen share codec',
@@ -269,29 +261,6 @@ export const ScreenShareHevcOptInControl = observer(() => {
);
});
export const EmulatedDecodeCodecCapControl = observer(() => {
const {i18n} = useLingui();
const options: ReadonlyArray<ComboboxOption<CodecPreference>> = [
{value: 'auto', label: i18n._(DECODE_CODEC_CAP_AUTO_DESCRIPTOR)},
{value: 'av1', label: 'AV1'},
{value: 'h265', label: 'H.265'},
{value: 'vp9', label: 'VP9'},
{value: 'h264', label: 'H.264'},
{value: 'vp8', label: 'VP8'},
];
return (
<Combobox<CodecPreference, false>
value={VoiceSettings.emulatedDecodeVideoCodecCap}
options={options}
onChange={(value) => VoiceSettingsCommands.update({emulatedDecodeVideoCodecCap: value})}
density="compact"
isSearchable={false}
aria-label={i18n._(DECODE_CODEC_CAP_DESCRIPTOR)}
data-flx="user.advanced-settings-tab.select.emulated-decode-codec-cap"
/>
);
});
export const OpenH264Control = observer(() => {
const {i18n} = useLingui();
const handleChange = useCallback((value: boolean) => {
fluxer_app/src/features/user/components/settings_utils/search_index/VoiceVideoIndex.ts
-22
View File
@@ -110,18 +110,6 @@ const OPENH264_VIDEO_CODEC_DESCRIPTOR = msg({
message: 'OpenH264 video codec',
comment: 'Settings search entry label. Names the settings search entry in the settings UI.',
});
const EMULATE_DECODE_CODEC_DESCRIPTOR = msg({
message: 'Emulate decode codec (testing)',
comment: 'Settings search entry label. Names the settings search entry in the settings UI.',
});
const CODEC_NEGOTIATION_TESTING_DESCRIPTOR = msg({
message: 'Codec negotiation testing',
comment: 'Settings search synonym. Used to match this term when the user types it in the settings search bar.',
});
const ADVERTISE_A_CAPPED_DECODE_CODEC_TO_FORCE_PUBLISHER_MIGRATION_DESCRIPTOR = msg({
message: 'Advertise a capped decode codec to force publisher migration',
comment: 'Settings search entry description. One-line summary of what the settings search entry controls.',
});
const H264_DESCRIPTOR = msg({
message: 'H.264',
comment: 'Settings search synonym. Used to match this term when the user types it in the settings search bar.',
@@ -248,16 +236,6 @@ export const voiceVideoIndex: Array<SearchableSettingDescriptor> = [
audience: 'advanced',
tags: ['media', 'voice'],
},
{
id: 'voice-video-emulated-decode-codec-cap',
tabType: 'voice_video',
sectionId: 'video',
label: EMULATE_DECODE_CODEC_DESCRIPTOR,
keywords: [CODEC_NEGOTIATION_TESTING_DESCRIPTOR, CODEC_DESCRIPTOR, VIDEO_CODEC_DESCRIPTOR],
description: ADVERTISE_A_CAPPED_DECODE_CODEC_TO_FORCE_PUBLISHER_MIGRATION_DESCRIPTOR,
audience: 'advanced',
tags: ['media', 'voice'],
},
{
id: 'voice-video-openh264-codec',
tabType: 'voice_video',