pepepper/fluxer
1
0 Fork 0
mirror of https://github.com/fluxerapp/fluxer synced 2026-10-17 21:15:32 +09:00
Code Issues Packages Projects Releases Wiki Activity

fix(voice): stop forcing automatic gain control off on every capture profile (#1781)

Browse Source
This commit is contained in:
Hampus authored and GitHub committed 2026-08-20 17:41:44 +02:00
1 parent 5331c0216a
commit c020eded31
6 files changed
+87 -22
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

fluxer_app/src/features/user/components/modals/tabs/UserVoiceTab.tsx
+15 -13
View File
@@ -169,8 +169,8 @@ const resolvePushToTalkReleaseDelayInput = (
).value;
};
const AUTO_GAIN_DESCRIPTION_DESCRIPTOR = msg({
message: 'Evens out your mic volume. Off when enhanced suppression is on.',
comment: 'Description for the automatic gain control toggle in the custom voice processing settings.',
message: 'Evens out your mic volume so you are not too quiet.',
comment: 'Description for the automatic gain control toggle in the voice processing settings.',
});
const INPUT_AND_OUTPUT_DESCRIPTOR = msg({
message: 'Input and output',
@@ -293,7 +293,6 @@ export const VoiceTab: React.FC<VoiceTabProps> = observer(({voiceSettings, autoR
},
];
const noiseSuppressionMethod = resolveNoiseSuppressionMethod(deepFilterNoiseSuppression, noiseSuppression);
const effectiveAutoGainControl = !deepFilterNoiseSuppression && autoGainControl;
const noiseSuppressionOptions: Array<ComboboxOption<NoiseSuppressionMethod>> = [
{value: 'enhanced', label: i18n._(NOISE_SUPPRESSION_ENHANCED_DESCRIPTOR)},
{value: 'standard', label: i18n._(NOISE_SUPPRESSION_STANDARD_DESCRIPTOR)},
@@ -449,6 +448,16 @@ export const VoiceTab: React.FC<VoiceTabProps> = observer(({voiceSettings, autoR
)}
</>
);
const renderAutoGainControlSwitch = () => (
<Switch
label={i18n._(VOICE_AUTOMATIC_GAIN_CONTROL_DESCRIPTOR)}
description={i18n._(AUTO_GAIN_DESCRIPTION_DESCRIPTOR)}
value={autoGainControl}
onChange={(value) => VoiceSettingsCommands.update({autoGainControl: value})}
ariaLabel={i18n._(VOICE_AUTOMATIC_GAIN_CONTROL_DESCRIPTOR)}
data-flx="user.voice-tab.render-auto-gain-control-switch.switch.update-auto-gain-control"
/>
);
const renderCustomProfile = () => (
<div className={styles.profileSubSection} data-flx="user.voice-tab.render-custom-profile.profile-sub-section">
{renderPttControls()}
@@ -507,15 +516,7 @@ export const VoiceTab: React.FC<VoiceTabProps> = observer(({voiceSettings, autoR
ariaLabel={i18n._(VOICE_ECHO_CANCELLATION_DESCRIPTOR)}
data-flx="user.voice-tab.render-custom-profile.switch.update--2"
/>
<Switch
label={i18n._(VOICE_AUTOMATIC_GAIN_CONTROL_DESCRIPTOR)}
description={i18n._(AUTO_GAIN_DESCRIPTION_DESCRIPTOR)}
value={effectiveAutoGainControl}
disabled={deepFilterNoiseSuppression}
onChange={(value) => VoiceSettingsCommands.update({autoGainControl: value})}
ariaLabel={i18n._(VOICE_AUTOMATIC_GAIN_CONTROL_DESCRIPTOR)}
data-flx="user.voice-tab.render-custom-profile.switch.update-auto-gain-control"
/>
{renderAutoGainControlSwitch()}
</div>
);
return (
@@ -662,6 +663,7 @@ export const VoiceTab: React.FC<VoiceTabProps> = observer(({voiceSettings, autoR
{voiceProcessingMode === 'voice' && (
<div className={styles.profileSubSection} data-flx="user.voice-tab.profile-sub-section">
{renderPttControls()}
{renderAutoGainControlSwitch()}
</div>
)}
{voiceProcessingMode === 'studio' && pttCombo?.key && isPushToTalk && (
@@ -682,7 +684,7 @@ export const VoiceTab: React.FC<VoiceTabProps> = observer(({voiceSettings, autoR
outputVolume,
echoCancellation,
noiseSuppression,
autoGainControl: effectiveAutoGainControl,
autoGainControl,
deepFilterNoiseSuppression,
deepFilterNoiseSuppressionLevel,
voiceProcessingMode,