fix(guild): render activity log entries deterministically (#2766)

fluxer_api/src/api/instance/InstanceConfigRepository.test.ts

@@ -21,6 +21,10 @@ import {
 	DEFAULT_EXPERIMENT_DELIVERY_CONFIG,
 	type ExperimentDeliveryConfig,
 } from '@fluxer/schema/src/domains/experiment/ExperimentSchemas';
+import {
+	DEFAULT_GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG,
+	type GuildActivityLogPresentationConfig,
+} from '@fluxer/schema/src/domains/experiment/GuildActivityLogPresentationSchemas';
 import {
 	DEFAULT_MESSAGE_HOVER_TRACKING_CONFIG,
 	type MessageHoverTrackingConfig,
@@ -35,6 +39,7 @@ const VOICE_NOISE_SUPPRESSION_CONFIG_KEY = 'voice_noise_suppression_config';
 const MESSAGE_HOVER_TRACKING_CONFIG_KEY = 'message_hover_tracking_config';
 const MESSAGE_KEYBOARD_FOCUS_CONFIG_KEY = 'message_keyboard_focus_config';
 const BLOCKED_MESSAGE_GROUPS_CONFIG_KEY = 'blocked_message_groups_config';
+const GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG_KEY = 'guild_activity_log_presentation_config';
 const EXPERIMENT_DELIVERY_CONFIG_KEY = 'experiment_delivery_config';
 const APP_PUBLIC_CONFIG_KEY = 'app_public_config';
 const INSTANCE_POLICY_CONFIG_KEY = 'instance_policy_config';
@@ -462,6 +467,55 @@ describe('InstanceConfigRepository', () => {
 		await expect(repository.getBlockedMessageGroupsConfig()).resolves.toEqual(config);
 	});
 
+	it('returns the default guild activity log presentation config when the key is absent', async () => {
+		const executor = new CountingInMemoryCassandraQueryExecutor();
+		setCassandraQueryExecutorForTesting(executor);
+		const kvProvider = new MockKVProvider();
+		const repository = createRepository(kvProvider);
+
+		await expect(repository.getGuildActivityLogPresentationConfig()).resolves.toEqual(
+			DEFAULT_GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG,
+		);
+	});
+
+	it.each([
+		{name: 'unparseable text', stored: 'not-json'},
+		{name: 'a json array', stored: '[]'},
+		{name: 'out-of-range values', stored: '{"rollout_basis_points":99999}'},
+		{name: 'a target that is not a snowflake', stored: '{"included_user_ids":["nope"]}'},
+	])('falls back to the default guild activity log presentation config for $name', async ({stored}) => {
+		const executor = new CountingInMemoryCassandraQueryExecutor();
+		setCassandraQueryExecutorForTesting(executor);
+		const kvProvider = new MockKVProvider();
+		const repository = createRepository(kvProvider);
+
+		await repository.setConfig(GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG_KEY, stored);
+
+		await expect(repository.getGuildActivityLogPresentationConfig()).resolves.toEqual(
+			DEFAULT_GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG,
+		);
+	});
+
+	it('round-trips a stored guild activity log presentation config', async () => {
+		const executor = new CountingInMemoryCassandraQueryExecutor();
+		setCassandraQueryExecutorForTesting(executor);
+		const kvProvider = new MockKVProvider();
+		const repository = createRepository(kvProvider);
+
+		const config: GuildActivityLogPresentationConfig = {
+			...DEFAULT_GUILD_ACTIVITY_LOG_PRESENTATION_CONFIG,
+			enabled: true,
+			config_version: 5,
+			rollout_basis_points: 2500,
+			rollout_salt: 'guild-activity-log-presentation-v2',
+			included_user_ids: ['1400000000000000001'],
+			excluded_user_ids: ['1400000000000000002'],
+		};
+		await repository.setGuildActivityLogPresentationConfig(config);
+
+		await expect(repository.getGuildActivityLogPresentationConfig()).resolves.toEqual(config);
+	});
+
 	it('fills newly added voice noise suppression fields from the schema defaults', async () => {
 		const executor = new CountingInMemoryCassandraQueryExecutor();
 		setCassandraQueryExecutorForTesting(executor);