fix(voice): send screen shares at the quality the user picked (#2840)

This commit is contained in:
Hampus
2026-09-19 16:46:22 +02:00
committed by GitHub
parent 2119e10ed5
commit 9027cbdf3e
102 changed files with 12454 additions and 20847 deletions
@@ -410,14 +410,6 @@ fn deserialize_instance_config_response_with_unknown_keys() {
"future_object_knob": {"nested": true},
"future_list_knob": ["a", "b"]
},
"screen_share_delivery": {
"enabled": false,
"config_version": 0,
"rollout_basis_points": 0,
"rollout_salt": "screen-share-delivery-v1",
"included_user_ids": [],
"excluded_user_ids": []
},
"experiment_delivery": {"poll_interval_seconds": 300, "poll_jitter_percent": 15},
"registration": {
"mode": "open",
-1
View File
@@ -465,7 +465,6 @@ async fn mutating_admin_pages_render_usable_csrf_tokens() {
"/instance-config?action=update_gateway_rollout",
"/instance-config?action=update_sso",
"/instance-config?action=update_voice_noise_suppression",
"/instance-config?action=update_screen_share_delivery",
"/instance-config?action=update_experiment_delivery",
][..],
),
@@ -95,39 +95,6 @@ async fn clearing_the_region_restriction_fields_reaches_the_api_as_empty_lists()
assert_eq!(body["allowed_guild_ids"], json!([]));
}
#[tokio::test]
async fn the_screen_share_delivery_form_keeps_the_included_and_excluded_lists_apart() {
let app = setup().await;
let csrf_token = csrf_token(&app).await;
let status = post_form(
&app,
"/instance-config?action=update_screen_share_delivery",
&format!(
"_csrf={csrf_token}&screen_share_delivery_enabled=true\
&screen_share_delivery_rollout_basis_points=2500\
&screen_share_delivery_rollout_salt=screen-share-delivery-v1\
&screen_share_delivery_included_user_ids=1500000000000000001\
&screen_share_delivery_excluded_user_ids=1500000000000000002"
),
)
.await;
assert_eq!(status, StatusCode::SEE_OTHER);
let body = captured_body(&app, "PATCH /admin/instance/config");
let delivery = &body["screen_share_delivery"];
assert_eq!(delivery["enabled"], json!(true));
assert_eq!(delivery["rollout_basis_points"], json!(2500));
assert_eq!(delivery["rollout_salt"], json!("screen-share-delivery-v1"));
assert_eq!(
delivery["included_user_ids"],
json!(["1500000000000000001"])
);
assert_eq!(
delivery["excluded_user_ids"],
json!(["1500000000000000002"])
);
}
struct TestApp {
router: Router,
session_cookie: String,