feat(desktop): sign every Windows release artifact (#1548)

This commit is contained in:
Hampus authored and GitHub committed 2026-08-10 23:22:19 +02:00
1 parent 873c203b5d
commit 6e66c92dca
89 files changed
+2408 -2740

No files matched your search

@@ -8,12 +8,9 @@ import type {
RegistrationResponseJSON,
} from '@simplewebauthn/browser';
export type DesktopBuildVariant = 'default' | 'windows-game-capture';
export interface DesktopInfo {
version: string;
channel: 'stable' | 'canary';
buildVariant: DesktopBuildVariant;
arch: string;
hardwareArch: string;
runningUnderRosetta: boolean;
@@ -308,7 +305,6 @@ export interface AppMetricsSnapshot {
export interface ElectronAPI {
platform: NodeJS.Platform;
buildVariant: DesktopBuildVariant;
getDesktopInfo: () => Promise<DesktopInfo>;
getGpuInfo?: () => Promise<GpuInfo>;
getAppMetrics?: () => Promise<AppMetricsSnapshot>;
@@ -19,7 +19,6 @@ export interface ClientInfo {
arch?: string;
desktopVersion?: string;
desktopChannel?: string;
desktopBuildVariant?: string;
desktopArch?: string;
desktopOS?: string;
desktopRunningUnderRosetta?: boolean;
@@ -47,13 +46,6 @@ export function formatReleaseChannelLabel(value: string): string {
return normalized.charAt(0).toUpperCase() + normalized.slice(1);
}
export function formatDesktopBuildVariantLabel(value: string): string {
if (value === 'windows-game-capture') {
return 'Windows Game Capture';
}
return value;
}
const ARCHITECTURE_PATTERNS: ReadonlyArray<{
pattern: RegExp;
label: string;
@@ -191,7 +183,6 @@ function getDesktopContextFromInfo(desktopInfo: DesktopInfo): Partial<ClientInfo
return {
desktopVersion: normalize(desktopInfo.version),
desktopChannel: normalize(desktopInfo.channel),
desktopBuildVariant: normalize(desktopInfo.buildVariant),
desktopArch: normalizeArchitectureValue(desktopInfo.hardwareArch ?? desktopInfo.arch),
desktopOS: normalize(desktopInfo.os),
desktopRunningUnderRosetta: desktopInfo.runningUnderRosetta,
@@ -312,14 +303,9 @@ export function formatClientBuildInfo(info: ClientInfo, options: {unknownLabel?:
const desktopChannel = info.desktopChannel ? formatReleaseChannelLabel(info.desktopChannel) : null;
const hasDesktopBuild = Boolean(info.desktopVersion);
const primaryDesktopChannel = desktopChannel ?? releaseChannel;
const desktopBuildVariant =
info.desktopBuildVariant && info.desktopBuildVariant !== 'default'
? formatDesktopBuildVariantLabel(info.desktopBuildVariant)
: null;
const webChannelPrefix = hasDesktopBuild && primaryDesktopChannel === releaseChannel ? '' : `${releaseChannel} `;
const parts = [
info.desktopVersion ? `${primaryDesktopChannel} Desktop ${info.desktopVersion}` : '',
desktopBuildVariant ? `Desktop variant ${desktopBuildVariant}` : '',
`${webChannelPrefix}Web ${buildVersion}`,
osDescription,
shouldShowBrowserInfo ? browserInfo : '',
@@ -406,7 +392,6 @@ export async function getGatewayClientProperties(geo?: {latitude?: string | null
build_version: Config.PUBLIC_BUILD_VERSION ?? 'dev',
desktop_app_version: info.desktopVersion ?? null,
desktop_app_channel: info.desktopChannel ?? null,
desktop_app_variant: info.desktopBuildVariant ?? null,
desktop_arch: info.desktopArch ?? info.arch ?? null,
desktop_os: info.desktopOS ?? info.osName ?? null,
e2ee_capable: isLiveKitE2EECapable(),