ci: add tests (#1141)

fluxer_gateway/src/guild/guild_common.erl

@@ -52,9 +52,7 @@ upsert_voice_state(ConnectionId, VoiceState, State) ->
         end,
     State#{voice_states => VoiceStates}.
 
--spec strip_members
-    (map()) -> map();
-    (term()) -> term().
+-spec strip_members(term()) -> term().
 strip_members(Data) when is_map(Data) ->
     Data1 = maps:remove(<<"members">>, Data),
     maps:remove(<<"member_role_index">>, Data1);

fluxer_gateway/src/guild/guild_data_index.erl

@@ -34,9 +34,7 @@
 
 -export_type([guild_data/0]).
 
--spec normalize_data
-    (map()) -> guild_data();
-    (term()) -> term().
+-spec normalize_data(term()) -> term().
 normalize_data(Data) when is_map(Data) ->
     Data0 =
         case guild_data_normalize:guild_data(Data) of

fluxer_gateway/src/guild/guild_data_index_channels.erl

@@ -40,9 +40,7 @@ channel_index(Data) when is_map(Data) ->
 channel_index(_) ->
     #{}.
 
--spec put_channels
-    (term(), guild_data()) -> guild_data();
-    (term(), term()) -> term().
+-spec put_channels(term(), term()) -> term().
 put_channels(Channels, Data) when is_map(Data) ->
     ChannelList = lists:filtermap(
         fun normalize_channel_item/1,

fluxer_gateway/src/guild/guild_data_index_roles.erl

@@ -37,9 +37,7 @@ role_index(Data) when is_map(Data) ->
 role_index(_) ->
     #{}.
 
--spec put_roles
-    (term(), guild_data()) -> guild_data();
-    (term(), term()) -> term().
+-spec put_roles(term(), term()) -> term().
 put_roles(Roles, Data) when is_map(Data) ->
     RoleList = [
         normalize_role(Role)

fluxer_gateway/src/guild/guild_data_normalize.erl

@@ -10,16 +10,13 @@
     channel/1
 ]).
 
--spec guild_data
-    (map()) -> map();
-    (term()) -> term().
+-spec guild_data(term()) -> term().
 guild_data(Data) when is_map(Data) ->
     normalize_nested_map(<<"guild">>, fun guild/1, Data);
 guild_data(Data) ->
     Data.
--spec member
-    (map()) -> map();
-    (term()) -> term().
+
+-spec member(term()) -> term().
 member(Member) when is_map(Member) ->
     Member1 = normalize_nested_map(<<"user">>, fun user/1, Member),
     Member2 = normalize_snowflake_list_field(<<"roles">>, Member1),
@@ -30,9 +27,7 @@ member(Member) when is_map(Member) ->
 member(Member) ->
     Member.
 
--spec role
-    (map()) -> map();
-    (term()) -> term().
+-spec role(term()) -> term().
 role(Role) when is_map(Role) ->
     Role1 = normalize_required_snowflake_field(<<"id">>, Role),
     Role2 = normalize_permission_field(<<"permissions">>, Role1),
@@ -44,9 +39,7 @@ role(Role) when is_map(Role) ->
 role(Role) ->
     Role.
 
--spec channel
-    (map()) -> map();
-    (term()) -> term().
+-spec channel(term()) -> term().
 channel(Channel) when is_map(Channel) ->
     Channel1 = normalize_required_snowflake_field(<<"id">>, Channel),
     Channel2 = normalize_optional_snowflake_field(<<"guild_id">>, Channel1),

fluxer_gateway/src/guild/guild_member_list_oset.erl

@@ -36,8 +36,7 @@ from_sorted(OSet, Keys) ->
 -spec destroy(oset()) -> ok.
 destroy(OSet) ->
     try guild_member_list_oset_nif:destroy(OSet) of
-        ok -> ok;
-        _ -> ok
+        ok -> ok
     catch
         _:_ -> ok
     end.

fluxer_gateway/src/guild/guild_member_list_oset_nif.erl

@@ -79,18 +79,18 @@ range(_OSet, _Start, _Count) ->
 to_list(_OSet) ->
     erlang:nif_error(nif_not_loaded).
 
--spec nif_path() -> file:filename().
+-spec nif_path() -> file:filename_all().
 nif_path() ->
     filename:join(priv_dir(), ?NIF_NAME).
 
--spec priv_dir() -> file:filename().
+-spec priv_dir() -> file:filename_all().
 priv_dir() ->
     case code:priv_dir(fluxer_gateway) of
         {error, _Reason} -> priv_dir_from_beam();
         Dir -> Dir
     end.
 
--spec priv_dir_from_beam() -> file:filename().
+-spec priv_dir_from_beam() -> file:filename_all().
 priv_dir_from_beam() ->
     case code:which(?MODULE) of
         Beam when is_list(Beam) ->

fluxer_gateway/src/guild/guild_presence_reconcile.erl

@@ -44,12 +44,12 @@ start_async(State) ->
         UserIds -> spawn_reconcile_fetch(UserIds, self())
     end.
 
--spec spawn_reconcile_fetch([user_id()], pid()) -> ok.
+-spec spawn_reconcile_fetch([user_id(), ...], pid()) -> ok.
 spawn_reconcile_fetch(UserIds, Parent) ->
     _ = spawn(fun() -> fetch_and_reply(UserIds, Parent) end),
     ok.
 
--spec fetch_and_reply([user_id()], pid()) -> ok.
+-spec fetch_and_reply([user_id(), ...], pid()) -> ok.
 fetch_and_reply(UserIds, Parent) ->
     Parent ! {presence_reconcile_apply, authoritative_presence_map(UserIds)},
     ok.
@@ -183,9 +183,7 @@ authoritative_presence(UserId) ->
         exit:_ -> undefined
     end.
 
--spec authoritative_presence_map([user_id()]) -> presence_by_id().
-authoritative_presence_map([]) ->
-    #{};
+-spec authoritative_presence_map([user_id(), ...]) -> presence_by_id().
 authoritative_presence_map(UserIds) ->
     lists:foldl(fun add_presence_to_map/2, #{}, safe_bulk_get(UserIds)).
 
@@ -199,8 +197,7 @@ add_presence_to_map(Presence, Acc) ->
 -spec safe_bulk_get([user_id()]) -> [presence()].
 safe_bulk_get(UserIds) ->
     try presence_cache:bulk_get(UserIds) of
-        Presences when is_list(Presences) -> Presences;
-        _ -> []
+        Presences -> Presences
     catch
         error:_ -> [];
         exit:_ -> []