fix(gateway): reject unknown rpc methods instead of crashing (#2238)

fluxer_api/src/api/infrastructure/GatewayService.ts

@@ -281,6 +281,8 @@ export class GatewayService {
 	private readonly MAX_BATCH_CONCURRENCY = 50;
 	private readonly PENDING_REQUEST_TIMEOUT_MS = ms('30 seconds');
 	private readonly AUTH_CONTEXT_FALLBACK_MS = ms('5 minutes');
+	private readonly BADGE_COUNTS_FALLBACK_MS = ms('5 minutes');
+	private badgeCountsUnsupportedUntil = 0;
 
 	constructor() {
 		this.rpcClient = GatewayRpcClient.getInstance();
@@ -703,15 +705,33 @@ export class GatewayService {
 	}
 
 	async invalidatePushBadgeCounts({userIds}: InvalidatePushBadgeCountsParams): Promise<void> {
+		if (Date.now() < this.badgeCountsUnsupportedUntil) {
+			await this.invalidatePushBadgeCountsIndividually(userIds);
+			return;
+		}
 		const batches: Array<Array<UserID>> = [];
 		for (let index = 0; index < userIds.length; index += PUSH_BADGE_COUNT_BATCH_SIZE) {
 			batches.push(userIds.slice(index, index + PUSH_BADGE_COUNT_BATCH_SIZE));
 		}
-		await Promise.all(
-			batches.map((batch) =>
-				this.call('push.invalidate_badge_counts', {user_ids: batch.map((userId) => userId.toString())}),
-			),
-		);
+		try {
+			await Promise.all(
+				batches.map((batch) =>
+					this.call('push.invalidate_badge_counts', {user_ids: batch.map((userId) => userId.toString())}),
+				),
+			);
+		} catch (error) {
+			const transformedError = this.transformGatewayError(error);
+			if (!this.isAuthContextUnsupportedError(transformedError)) {
+				throw transformedError;
+			}
+			this.badgeCountsUnsupportedUntil = Date.now() + this.BADGE_COUNTS_FALLBACK_MS;
+			Logger.warn({error}, '[gateway-rpc] push.invalidate_badge_counts unavailable, falling back to per-user calls');
+			await this.invalidatePushBadgeCountsIndividually(userIds);
+		}
+	}
+
+	private async invalidatePushBadgeCountsIndividually(userIds: ReadonlyArray<UserID>): Promise<void> {
+		await Promise.all(userIds.map((userId) => this.invalidatePushBadgeCount({userId})));
 	}
 
 	async invalidatePushSubscriptions({userId}: InvalidatePushSubscriptionsParams): Promise<void> {